Closed
Bug 2078249
Opened 28 days ago
Closed 27 days ago
use threading.Event().wait() rather than time.sleep() in moz-phab spinner/wait message
Categories
(Conduit :: moz-phab, enhancement)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ollie, Assigned: ollie)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(1 external file)
moz-phab version (from moz-phab version): latest
As seen in this profile, moz-phab spends quite a lot of time (approx 18% of run time) waiting for time.sleep(0.2) calls rendering the Spinner when performing operations.
This time could be gained back by using a threading.Event().wait() rather than a time.sleep(), as the event can be signaled immediately when the operation completes.
|
Assignee | |
Updated•28 days ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•28 days ago
|
||
|
||
Updated•28 days ago
|
Attachment #9653071 -
Attachment description: WIP: Bug 2078249 - replace time.sleep() calls with threading.Event().wait() in Spinner implementation. r?sheehan → Bug 2078249 - replace time.sleep() calls with threading.Event().wait() in Spinner implementation. r?sheehan
|
||
Comment 2•27 days ago
|
||
Authored by https://github.com/olliehcrook
https://github.com/mozilla-conduit/review/commit/3ed785033bd382442b3aa813e3d3d032c6e9be1e
[main] Bug 2078249 - replace time.sleep() calls with threading.Event().wait() in Spinner implementation. r=sheehan
(via GitHub webhook, authenticated as shared-secret)
Status: ASSIGNED → RESOLVED
Closed: 27 days ago
Resolution: --- → FIXED
|
||
Updated•27 days ago
|
Blocks: moz-phab-perf
You need to log in
before you can comment on or make changes to this bug.
Description
•