Repository navigation
fix: decouple interactive REPL buffer from target output format - #57
Merged
Merged
Conversation
JFryy
marked this pull request as ready for review
November 2, 2026 18:50
JFryy
previously approved these changes
Nov 2, 2026
JFryy
left a comment
Owner
There was a problem hiding this comment.
Thanks for all your submissions, this looks good just a few nits I'll tweak before merge.
Interact returned the same result for a failure to start the interface as for the user quitting, so qq printed "Exited without executing query" and exited 0. Return the error and exit 1, as before this change. Write the query banner and exit notice to stderr so stdout holds only the result in the selected output format.
JFryy
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the TUI interactive REPL to decouple its internal live-query parsing state buffer from the target output format, resolving live rendering failures when transcoding to non-JSON codecs.
Key Changes
internal/tui/interactive.gointo a separate helpermapToSlice(m map[string]struct{})to satisfy static analysis checkers (like Semgrep).Justification & Upstream Value
Verification and Testing
qq -Ion YAML and TOML inputs. Live rendering now previews correctly, and exit formatting successfully outputs to the target codecs.