Repository navigation
Fix Terraform object attributes in HCL round trips - #66
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #60
Fix Terraform/HCL round trips: preserve object attributes, reconstruct labeled and repeated blocks, and keep references and expressions executable instead of turning them into literal strings. Templates, escaped literal markers, and expressions inside objects/lists follow hcl2json's encoding. Preserve timestamps and numeric types from other codecs, and reject malformed expressions.
Tests now evaluate the original and rewritten
tests/test.tfwith the same variables and compare attribute values/types and block structure. The fixture includes repeated filters. Additional coverage includes conditionals, function calls, templates, computed keys, escaped literals, and the TOML/MessagePack conversions that previously failed CI.Plain JSON still cannot distinguish object-list attributes from repeated blocks without a schema; the writer follows hcl2json's block convention. Formatting and comments are not preserved.