Skip to content

[csharp] Extend HostConfiguration with additional AddApiHttpClients signatures - #22500

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
daberni:feature/csharp-httpclients-serviceprovider
Jun 8, 2026
Merged

wing328 merged 1 commit into
OpenAPITools:masterfrom
daberni:feature/csharp-httpclients-serviceprovider

Conversation

@daberni

@daberni daberni commented Dec 6, 2025

Copy link
Copy Markdown
Contributor

This change adds new Method signatures to the HostConfiguration in regards of AddApiHttpClients to support also the AddHttpClient(Action<IServiceProvider, HttpClient> configureClient) variant. This allows to access the ServiceProvider during configuration which can be very benefitial.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean (2017/08) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)

@daberni
daberni force-pushed the feature/csharp-httpclients-serviceprovider branch from 6eb5add to ed56c22 Compare December 6, 2025 22:33
@daberni
daberni force-pushed the feature/csharp-httpclients-serviceprovider branch from ed56c22 to 132cc6d Compare December 6, 2025 22:38
@daberni

daberni commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

@wing328 it looks like the suggested technical committee members are quite inactive at the moment. What would be the best way to still be able to contribute to these projects when there is no one approving the pull requests?

@devhl-labs

Copy link
Copy Markdown
Contributor

LGTM, lets try it @wing328

@daberni

daberni commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

@wing328 any chance of getting this PR merged?

@daberni

daberni commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

@wing328 as you merged another csharp bugfix from me recently, this would fit in quite well to in the next release imho

@wing328
wing328 merged commit 5e44ee2 into OpenAPITools:master Jun 8, 2026
61 checks passed
@wing328

wing328 commented Jun 8, 2026

Copy link
Copy Markdown
Member

Thanks for the reminder. Just merged it. Sorry for the delay as there are too many PRs.

@wing328 wing328 added this to the 7.23.0 milestone Jun 8, 2026
@daberni
daberni deleted the feature/csharp-httpclients-serviceprovider branch June 8, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Sponsor
SponsoredKunjungi sekarang
Promo