Skip to content

Started to make the FFmpeg filter chain work together - #874

Closed
SubJunk wants to merge 1 commit into
masterfrom
FFmpegFilterChain
Closed

SubJunk wants to merge 1 commit into
masterfrom
FFmpegFilterChain

Conversation

@SubJunk

@SubJunk SubJunk commented Apr 9, 2016

Copy link
Copy Markdown
Member

This change is Reviewable

@SubJunk

SubJunk commented Apr 9, 2016

Copy link
Copy Markdown
Member Author

@UniversalMediaServer/developers I'm interested in your opinion on this. Basically I noticed a bug that happens when we use multiple filters, and it seems to be caused by our filter chain not being synchronized. For example, this is what we are outputting now which fails:

ffmpeg -y -loglevel info -i input.mkv -filter_complex pad=iw:iw/(16/9):0:(oh-ih)/2,scale=1920:1080,[0:v][0:s:0]overlay -bufsize 31250000 -maxrate 31250000 -crf 19 -c:a copy -c:v libx264 -tune zerolatency -level 31 -pix_fmt yuv420p -f mpegts -preset superfast output.mpeg

and it should be something like this:

ffmpeg -y -loglevel info -i input.mkv -filter_complex [0:v]pad=iw:iw/(16/9):0:(oh-ih)/2[v],[v]scale=1920:1080[v],[v][0:s:0]overlay[v] -map "[v]" -bufsize 31250000 -maxrate 31250000 -crf 19 -c:a copy -c:v libx264 -tune zerolatency -level 31 -pix_fmt yuv420p -f mpegts -preset superfast output.mpeg

Do you have any ideas about the best way to implement this in the code? I've done an attempt in this PR.

@Sami32

Sami32 commented Jun 19, 2016 •

Copy link
Copy Markdown
Contributor

@SubJunk SubJunk closed this Jun 2, 2018
@SubJunk
SubJunk deleted the FFmpegFilterChain branch June 2, 2018 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants