Repository navigation
[text-box-trim] - #78741
Open
alanbaradlay wants to merge 2 commits into
Open
[text-box-trim]#78741alanbaradlay wants to merge 2 commits into
alanbaradlay wants to merge 2 commits into
Conversation
…or trim-start https://bugs.webkit.org/show_bug.cgi?id=329340 <rdar://problem/191239706> Reviewed by NOBODY (OOPS!). text-box-trim trims the block-start and block-end sides of an inline box, but textBoxAdjustedInlineBoxHeight always applied trim-start to the line-over side (ascent) and trim-end to the line-under side (descent). In vertical-lr, where lines are inverted, the block-start side is the line-under side, so the wrong side got trimmed. Map trim-start and trim-end through WritingMode::isLineInverted(), the same way line box trimming already does in LayoutIntegrationLineLayout. This progresses the vertical-lr variants of text-box-trim-inline-box-00{1,2,4,5}.html and the vertical-lr,alphabetic variants of text-box-trim-inline-box-text-decoration-00{1,2}.html. Their vertical-lr,ideographic-ink variants now trim the line-under side with the (unimplemented) ideographic-ink edge, which asserts in debug builds. * LayoutTests/TestExpectations: * Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp: (WebCore::Layout::textBoxAdjustedInlineBoxHeight):
…med edge https://bugs.webkit.org/show_bug.cgi?id=329370 <rdar://problem/191255274> Reviewed by NOBODY (OOPS!). The decorating box of a trimmed inline box is moved to its trimmed edge (textBoxEdgeAdjustmentForUnderline), and underlineOffsetForTextBoxPainting subtracts that adjustment again so that the underline stays where it would be without text-box-trim. overlineOffsetForTextBoxPainting did not, so the overline moved down with the trim. Subtract the adjustment for the overline too. This progresses the horizontal cap and ex variants of text-box-trim-inline-box-text-decoration-001.html. * LayoutTests/TestExpectations: * Source/WebCore/style/InlineTextBoxStyle.cpp: (WebCore::overlineOffsetForTextBoxPainting):
Collaborator
|
EWS run on current version of this PR (hash 6630190) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧪 wpe-wk2
🧪 api-mac
6630190
cd20818
6630190