Repository navigation
Cherry-pick(s) c01cc7d0deac. rdar://191051301 - #78742
Open
webkit-opensource-integration wants to merge 1 commit into
Open
webkit-opensource-integration wants to merge 1 commit into
webkit-opensource-integration wants to merge 1 commit into
Conversation
…e is referenced by JS https://bugs.webkit.org/show_bug.cgi?id=322208 rdar://183926623 rdar://183926406 Reviewed by Geoffrey Garen. Keep the shadow host and its ancestors when there is a JS reference to a node within its shadow tree. This is a GC correctness fix and also a hardening for webkit.org/b/321943 / rdar://178311709. Tests: fast/shadow-dom/remove-shadow-host-keeps-shadow-tree-attached.html fast/shadow-dom/remove-shadow-host-stale-shadow-including-root-crash.html * LayoutTests/fast/shadow-dom/remove-shadow-host-keeps-shadow-tree-attached-expected.txt: Added. * LayoutTests/fast/shadow-dom/remove-shadow-host-keeps-shadow-tree-attached.html: Added. * LayoutTests/fast/shadow-dom/remove-shadow-host-stale-shadow-including-root-crash-expected.txt: Added. * LayoutTests/fast/shadow-dom/remove-shadow-host-stale-shadow-including-root-crash.html: Added. * Source/WebCore/bindings/js/JSNodeCustom.h: (WebCore::willCreatePossiblyOrphanedTreeByRemoval): * Source/WebCore/dom/ContainerNodeAlgorithms.cpp: (WebCore::observabilityOfRemovedNode): (WebCore::observabilityOfRemovedShadowRoot): (WebCore::notifyNodeRemovedFromDocument): (WebCore::notifyNodeRemovedFromTree): Originally-landed-as: 316606.425@safari-7625-branch (c01cc7d). rdar://191051301
webkit-opensource-integration
requested review from
cdumez and
rniwa
as code owners
October 29, 2026 00:58
Author
Author
|
At the time this pull request was created the following files were in conflict and need to be resolved:
|
Collaborator
|
EWS run on current version of this PR (hash c562008) Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration has hit a merge conflict while cherry-picking rdar://191051301 to main. [c01cc7d] caused a merge conflict.
ℹ️ Info
RC_REMOVE_SEC_ACCEL_*guards were removed with unifdef before cherry-picking, keeping only the code built when the macro is not defined.c562008