Skip to content

Annotate more classes in WebCore/editing with TZone macros - #78753

Draft
vigneshrao-apple wants to merge 1 commit into
WebKit:mainfrom
vigneshrao-apple:eng/Move-objects-in-WebCore-editing-to-the-TZone-heap
Draft

vigneshrao-apple wants to merge 1 commit into
WebKit:mainfrom
vigneshrao-apple:eng/Move-objects-in-WebCore-editing-to-the-TZone-heap

Conversation

@vigneshrao-apple

@vigneshrao-apple vigneshrao-apple commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

f197905

Annotate more classes in WebCore/editing with TZone macros
https://bugs.webkit.org/show_bug.cgi?id=329289
rdar://191231625

Reviewed by NOBODY (OOPS!).

This moves most of the classes in Source/WebCore/editing to the TZone heap. A few
more classes remain here but they require more review and will be landed
separately.

No new tests since the existing ones should cover this.

* Source/WebCore/editing/AppendNodeCommand.cpp:
* Source/WebCore/editing/AppendNodeCommand.h:
* Source/WebCore/editing/ApplyStyleCommand.cpp:
* Source/WebCore/editing/ApplyStyleCommand.h:
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
* Source/WebCore/editing/BreakBlockquoteCommand.h:
* Source/WebCore/editing/ChangeListTypeCommand.cpp:
* Source/WebCore/editing/ChangeListTypeCommand.h:
* Source/WebCore/editing/CompositeEditCommand.cpp:
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/CreateLinkCommand.cpp:
* Source/WebCore/editing/CreateLinkCommand.h:
* Source/WebCore/editing/CustomUndoStep.cpp:
* Source/WebCore/editing/CustomUndoStep.h:
* Source/WebCore/editing/DeleteFromTextNodeCommand.cpp:
* Source/WebCore/editing/DeleteFromTextNodeCommand.h:
* Source/WebCore/editing/DeleteSelectionCommand.cpp:
* Source/WebCore/editing/DeleteSelectionCommand.h:
* Source/WebCore/editing/DictationCommand.cpp:
* Source/WebCore/editing/DictationCommand.h:
* Source/WebCore/editing/Editor.cpp:
* Source/WebCore/editing/FormatBlockCommand.cpp:
* Source/WebCore/editing/FormatBlockCommand.h:
* Source/WebCore/editing/IndentOutdentCommand.cpp:
* Source/WebCore/editing/IndentOutdentCommand.h:
* Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:
* Source/WebCore/editing/InsertIntoTextNodeCommand.h:
* Source/WebCore/editing/InsertLineBreakCommand.cpp:
* Source/WebCore/editing/InsertLineBreakCommand.h:
* Source/WebCore/editing/InsertListCommand.cpp:
* Source/WebCore/editing/InsertListCommand.h:
* Source/WebCore/editing/InsertNestedListCommand.cpp:
* Source/WebCore/editing/InsertNestedListCommand.h:
* Source/WebCore/editing/InsertNodeBeforeCommand.cpp:
* Source/WebCore/editing/InsertNodeBeforeCommand.h:
* Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:
* Source/WebCore/editing/InsertParagraphSeparatorCommand.h:
* Source/WebCore/editing/InsertTextCommand.cpp:
* Source/WebCore/editing/InsertTextCommand.h:
* Source/WebCore/editing/MergeIdenticalElementsCommand.cpp:
* Source/WebCore/editing/MergeIdenticalElementsCommand.h:
* Source/WebCore/editing/ModifySelectionListLevel.cpp:
* Source/WebCore/editing/ModifySelectionListLevel.h:
* Source/WebCore/editing/MoveSelectionCommand.cpp:
* Source/WebCore/editing/MoveSelectionCommand.h:
* Source/WebCore/editing/RemoveFormatCommand.cpp:
* Source/WebCore/editing/RemoveFormatCommand.h:
* Source/WebCore/editing/RemoveNodeCommand.cpp:
* Source/WebCore/editing/RemoveNodeCommand.h:
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp:
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.h:
* Source/WebCore/editing/ReplaceRangeWithTextCommand.cpp:
* Source/WebCore/editing/ReplaceRangeWithTextCommand.h:
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
* Source/WebCore/editing/ReplaceSelectionCommand.h:
* Source/WebCore/editing/SetNodeAttributeCommand.cpp:
* Source/WebCore/editing/SetNodeAttributeCommand.h:
* Source/WebCore/editing/SetSelectionCommand.cpp:
* Source/WebCore/editing/SetSelectionCommand.h:
* Source/WebCore/editing/SimplifyMarkupCommand.cpp:
* Source/WebCore/editing/SimplifyMarkupCommand.h:
* Source/WebCore/editing/SpellChecker.cpp:
* Source/WebCore/editing/SpellChecker.h:
* Source/WebCore/editing/SpellingCorrectionCommand.cpp:
* Source/WebCore/editing/SpellingCorrectionCommand.h:
* Source/WebCore/editing/SplitElementCommand.cpp:
* Source/WebCore/editing/SplitElementCommand.h:
* Source/WebCore/editing/SplitTextNodeCommand.cpp:
* Source/WebCore/editing/SplitTextNodeCommand.h:
* Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp:
* Source/WebCore/editing/SplitTextNodeContainingElementCommand.h:
* Source/WebCore/editing/TextInsertionBaseCommand.cpp:
* Source/WebCore/editing/TextInsertionBaseCommand.h:
* Source/WebCore/editing/TypingCommand.cpp:
* Source/WebCore/editing/TypingCommand.h:
* Source/WebCore/editing/UnlinkCommand.cpp:
* Source/WebCore/editing/UnlinkCommand.h:
* Source/WebCore/editing/VisibleSelection.cpp:
* Source/WebCore/editing/VisibleSelection.h:
* Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp:
* Source/WebCore/editing/WrapContentsInDummySpanCommand.h:
* Source/WebCore/editing/WritingToolsCompositionCommand.cpp:
* Source/WebCore/editing/WritingToolsCompositionCommand.h:

f197905

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows Apple Internal
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 win ❌ 🛠 ios-apple
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-cmake-debug ✅ 🧪 wpe-wk2 ✅ 🧪 win-tests ❌ 🛠 mac-apple
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe ❌ 🛠 vision-apple
✅ 🧪 ios-wk2-wpt ✅ 🧪 api-mac-cmake-debug
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🛠 gtk3-gcc
✅ 🛠 ios-safer-cpp ✅ 🧪 mac-cmake-debug-wk2 ✅ 🛠 gtk
✅ 🛠 vision ✅ 🧪 gtk-wk2
✅ 🛠 vision-sim ✅ 🧪 mac-intel-wk2 ✅ 🧪 api-gtk
✅ 🧪 vision-wk2 ✅ 🛠 mac-safer-cpp   🛠 playstation
✅ 🛠 tv ✅ 🧪 mac-site-isolation
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=329289
rdar://191231625

Reviewed by NOBODY (OOPS!).

This moves most of the classes in Source/WebCore/editing to the TZone heap. A few
more classes remain here but they require more review and will be landed
separately.

No new tests since the existing ones should cover this.

* Source/WebCore/editing/AppendNodeCommand.cpp:
* Source/WebCore/editing/AppendNodeCommand.h:
* Source/WebCore/editing/ApplyStyleCommand.cpp:
* Source/WebCore/editing/ApplyStyleCommand.h:
* Source/WebCore/editing/BreakBlockquoteCommand.cpp:
* Source/WebCore/editing/BreakBlockquoteCommand.h:
* Source/WebCore/editing/ChangeListTypeCommand.cpp:
* Source/WebCore/editing/ChangeListTypeCommand.h:
* Source/WebCore/editing/CompositeEditCommand.cpp:
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/CreateLinkCommand.cpp:
* Source/WebCore/editing/CreateLinkCommand.h:
* Source/WebCore/editing/CustomUndoStep.cpp:
* Source/WebCore/editing/CustomUndoStep.h:
* Source/WebCore/editing/DeleteFromTextNodeCommand.cpp:
* Source/WebCore/editing/DeleteFromTextNodeCommand.h:
* Source/WebCore/editing/DeleteSelectionCommand.cpp:
* Source/WebCore/editing/DeleteSelectionCommand.h:
* Source/WebCore/editing/DictationCommand.cpp:
* Source/WebCore/editing/DictationCommand.h:
* Source/WebCore/editing/Editor.cpp:
* Source/WebCore/editing/FormatBlockCommand.cpp:
* Source/WebCore/editing/FormatBlockCommand.h:
* Source/WebCore/editing/IndentOutdentCommand.cpp:
* Source/WebCore/editing/IndentOutdentCommand.h:
* Source/WebCore/editing/InsertIntoTextNodeCommand.cpp:
* Source/WebCore/editing/InsertIntoTextNodeCommand.h:
* Source/WebCore/editing/InsertLineBreakCommand.cpp:
* Source/WebCore/editing/InsertLineBreakCommand.h:
* Source/WebCore/editing/InsertListCommand.cpp:
* Source/WebCore/editing/InsertListCommand.h:
* Source/WebCore/editing/InsertNestedListCommand.cpp:
* Source/WebCore/editing/InsertNestedListCommand.h:
* Source/WebCore/editing/InsertNodeBeforeCommand.cpp:
* Source/WebCore/editing/InsertNodeBeforeCommand.h:
* Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:
* Source/WebCore/editing/InsertParagraphSeparatorCommand.h:
* Source/WebCore/editing/InsertTextCommand.cpp:
* Source/WebCore/editing/InsertTextCommand.h:
* Source/WebCore/editing/MergeIdenticalElementsCommand.cpp:
* Source/WebCore/editing/MergeIdenticalElementsCommand.h:
* Source/WebCore/editing/ModifySelectionListLevel.cpp:
* Source/WebCore/editing/ModifySelectionListLevel.h:
* Source/WebCore/editing/MoveSelectionCommand.cpp:
* Source/WebCore/editing/MoveSelectionCommand.h:
* Source/WebCore/editing/RemoveFormatCommand.cpp:
* Source/WebCore/editing/RemoveFormatCommand.h:
* Source/WebCore/editing/RemoveNodeCommand.cpp:
* Source/WebCore/editing/RemoveNodeCommand.h:
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp:
* Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp:
* Source/WebCore/editing/ReplaceNodeWithSpanCommand.h:
* Source/WebCore/editing/ReplaceRangeWithTextCommand.cpp:
* Source/WebCore/editing/ReplaceRangeWithTextCommand.h:
* Source/WebCore/editing/ReplaceSelectionCommand.cpp:
* Source/WebCore/editing/ReplaceSelectionCommand.h:
* Source/WebCore/editing/SetNodeAttributeCommand.cpp:
* Source/WebCore/editing/SetNodeAttributeCommand.h:
* Source/WebCore/editing/SetSelectionCommand.cpp:
* Source/WebCore/editing/SetSelectionCommand.h:
* Source/WebCore/editing/SimplifyMarkupCommand.cpp:
* Source/WebCore/editing/SimplifyMarkupCommand.h:
* Source/WebCore/editing/SpellChecker.cpp:
* Source/WebCore/editing/SpellChecker.h:
* Source/WebCore/editing/SpellingCorrectionCommand.cpp:
* Source/WebCore/editing/SpellingCorrectionCommand.h:
* Source/WebCore/editing/SplitElementCommand.cpp:
* Source/WebCore/editing/SplitElementCommand.h:
* Source/WebCore/editing/SplitTextNodeCommand.cpp:
* Source/WebCore/editing/SplitTextNodeCommand.h:
* Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp:
* Source/WebCore/editing/SplitTextNodeContainingElementCommand.h:
* Source/WebCore/editing/TextInsertionBaseCommand.cpp:
* Source/WebCore/editing/TextInsertionBaseCommand.h:
* Source/WebCore/editing/TypingCommand.cpp:
* Source/WebCore/editing/TypingCommand.h:
* Source/WebCore/editing/UnlinkCommand.cpp:
* Source/WebCore/editing/UnlinkCommand.h:
* Source/WebCore/editing/VisibleSelection.cpp:
* Source/WebCore/editing/VisibleSelection.h:
* Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp:
* Source/WebCore/editing/WrapContentsInDummySpanCommand.h:
* Source/WebCore/editing/WritingToolsCompositionCommand.cpp:
* Source/WebCore/editing/WritingToolsCompositionCommand.h:
@vigneshrao-apple vigneshrao-apple self-assigned this Oct 29, 2026
@vigneshrao-apple vigneshrao-apple added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Oct 29, 2026
@vigneshrao-apple
vigneshrao-apple marked this pull request as draft October 29, 2026 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Bugs Unclassified bugs are placed in this component until the correct component can be determined.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants