Repository navigation
Enhance reliability of how Site Health enqueued assets module detects assets #135
Description
The initial implementation for the Site Health enqueued assets module (see #25) is a solid start, but there's room for enhancement in how reliably it detects enqueued assets. This was already pointed out in the initial PR review, but it was decided to merge the large first PR first and then implement this enhancement separately, to allow for a more focused review.
This issue is primarily to address the following review comment: #54 (comment)
There are potentially more aspects we can improve around this, let's explore this here.
Activity
felixarntz commentedon Jan 28, 2022
@aristath Anything to add? Do you think this is already good to open a PR for addressing your comment, or should we evaluate the technical approach a bit more before writing code?
cc @manuelRod
aristath commentedon Jan 28, 2022
Assigning this one to myself so I can take a look again on Monday.
I think the code posted in #54 (comment) will be a good starting point, I'll just need to polish and properly test it before submitting a PR 👍
manuelRod commentedon Jan 28, 2022
Hello, @aristath @felixarntz I was working already on the proposed enhances, I didn't realise you have merged the previous PR :D
Anyways, here is the new PR with a few of the things addressed, we can keep the conversation going on there!
#136
felixarntz commentedon Jan 28, 2022
@manuelRod Oh, sorry about that - I guess I merged that a bit too quickly. But that's great, will review soon!
manuelRod commentedon Feb 28, 2022
@aristath can you review this PR too?
felixarntz commentedon Mar 7, 2022
Fixed via #136