Skip to content

NPM script to update @since n.e.x.t tags - #178

Merged
felixarntz merged 6 commits into
trunkfrom
feature/since-tag
Feb 22, 2022
Merged

felixarntz merged 6 commits into
trunkfrom
feature/since-tag

Conversation

@eugene-manuilov

Copy link
Copy Markdown
Contributor

Summary

Fixes #90

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@eugene-manuilov eugene-manuilov added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 18, 2022

@felixarntz felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugene-manuilov Looks great, only one point of feedback.

Comment thread bin/plugin/commands/since.js Outdated

@felixarntz felixarntz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eugene-manuilov Thanks, this looks great!

cc @JustinyAhin for the updated release instructions

@JustinyAhin JustinyAhin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me too.
Thanks @eugene-manuilov

@felixarntz
felixarntz merged commit 28ba720 into trunk Feb 22, 2022
@tillkruss
tillkruss deleted the feature/since-tag branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automate @since tags generation using the n.e.x.t placeholders

3 participants