Repository navigation
Make channel ID and name configurable in DefaultMediaNotificationProvider #104
Description
Use case description
After integrating your DefaultMediaNotificationProvider with the MediaSessionService, I found that there are a few points worth to be discussed, but before jumping into them, I'd like to make sure that I understand the purpose of this class correctly.
Our use case is quite straightforward, displaying media notification for audio playback with custom actions, and the notification building/ bitmap handling in DefaultMediaNotificationProvider is exactly what I need, so I chose to extend this class, provide own BitmapLoader implementation, and override the member functions to achieve the custom actions rather than providing full-blown implementation from scratch.
Everything is working fine, but here are a few things that our team and I think would be nice to improve:
- The
Defaultnaming prefix of the class made me think that we should provide our own implementation originally, but turns out it's quite flexible and we can just extend from it. Maybe a better naming is possible here? - Notification channel id and name are too generic and can't be overridden, we actually would like to provide translations for the channel naming if possible.
- The only way to provide own playback icons is to override by the same resource name, we think that a proper API to override the resources will be a neater solution.
Please let us know your thought about those points, we'll be glad if any of them makes sense to you! Thanks as always.
Activity
[-]Feature requests for DefaultMediaNotificationProvider[/-][+]Make channel ID and name configurable in DefaultMediaNotificationProvider[/+]marcbaechinger commentedon Jul 4, 2022
The naming comes from our convention to have an interface defined from a component like
MediaNotification.Provider. Apps can provide their own or then use the default implementation provided by the library that isDefaultMediaNotificationProviderin this case. We try to make the default implementation as flexible and customizable as possible, so if we do a good job, most app don't need to implement their own can can go with the default. I don't think the naming schema is in question for these reasons.You can override the drawables resource names for existing buttons as you already mentioned. The API allows you to do your own buttons by overriding
DefaultMediaNotificationProvider.getMediaButtons. This way you can create your ownCommandButtonsfor playback or custom commands as well. These buttons can have any resources you chose. Please note that any change you make for theMediaNotification.Providershould be reflected in the allowed commands of the session for Android 13 that is using a mini player based on the media session only (eg. hiding skip to next/previous). I don't think you can customize the icons of playback commands in the mini. player. So take a look at that to make sure your icons are consistent on for instance Android 12 (Notification with PendingIntents that allow customization of the icons) and Android 13 (mini player with standard icons defined by System UI).Lastly, we should make the channel ID and the channel name configurable for the
DefaultMediaNotificationProvider. I rename this issue to this as I think this is what we should provide out of the feature requests.kevinguitar commentedon Jul 5, 2022
@marcbaechinger Thanks for the reply and tip!
Sorry for not being clear, I actually meant the small notification icon (
media3_notification_small_icon), as thecreateNotificationfunction is final, the only way to provide the icon is to override it in the top-level module, it's working fine but just a bit implicit and hard to trace, do you think we can at least have an API to provide own small icon?Make DefaultMediaNotificationProvider more configurable
christosts commentedon Jul 22, 2022
We changed DefaultMediaNotificationProvider so that
default_notification_channel_name.The commit will appear here once it's pushed to the main branch. I'll close this issue but feel free to re-open if something did not work as expected.
Make DefaultMediaNotificationProvider more configurable