After running into a stream error with subtitle track, playback gets stuck every time the subtitle cue is empty #2328

Activity

1. vkoehler

   added

   bug

   needs triage

   on Apr 11, 2025
2. vkoehler commented on Apr 11, 2025

   

   vkoehler

   on Apr 11, 2025

   Author

   More actions

   We have some channels, that only provide subtitles for certain shows during the day. For the rest of the shows the subtitle cue is empty. Even for the channels, that provide subtitles for every show, it's not guaranteed, that the subtitle cue is always not empty. Typically during the ad breaks, there will be no input for the subtitle cue.

   I checked the implementation of the isReady() function of the TextRenderer and I see following reasons for this behavior:

   1. Once streamError is set, it will never be cleared.
   2. Once streamError is set, following check "checkNotNull(cuesResolver).getNextCueChangeTimeUs(lastRendererPositionUs) != C.TIME_END_OF_SOURCE" will lead to a not ready state of the TextRenderer whenever the subtitle cue is empty.

   It would help to reset streamError after the subtitle track is disabled. I tried to do it inside of onPositionReset() of TextRenderer and it seems to work, but I'm not sure if it's the right place to do it.

   Also after the subtitle track gets disabled after stream error, I would expect this state to be reflected in onTracksChanged() of Player.Listener, but I see, that the subtitle track stays selected. Is my expectation correct or is there another way how to make the state of the subtitle track transparent to the user?

   👍React with 👍1Reacted by Gunnar Adler
3. marcbaechinger

   assigned

   marcbaechinger

   and

   icbaker

   and unassigned

   marcbaechinger

   on Apr 14, 2025
4. icbaker commented on Apr 28, 2025

   

   icbaker

   on Apr 28, 2025

   Collaborator

   More actions

   playlist will be sent via email

   I initially struggled to find this because it was sent with the subject Issue #2283, which is a different issue you filed.

   ---

   I can reproduce the issue using the steps provided.

   I've sent a fix for review which clears the streamError in both TextRenderer.onStreamChanged and onDisabled.
5. icbaker

   removed

   needs triage

   on Apr 28, 2025
6. copybara-service

   added a commit that references this issue on Apr 29, 2025

   Clear `TextRenderer.streamError` when disabling or changing stream

   ...

   ecfd9d1
7. icbaker commented on Apr 29, 2025

   

   icbaker

   on Apr 29, 2025

   Collaborator

   More actions

   This is fixed by the commit linked above.
8. icbaker

   closed this as completedon Apr 29, 2025
9. androidx

   locked and limited conversation to collaborators on Jun 29, 2025