Skip to content

SsaDecoder does not support utf-16 encoded ass files #319

Closed

Description

@viqbgrg

Media3 Version

Media3 1.0.0

Devices that reproduce the issue

redmi k30pro running android 12

Devices that do not reproduce the issue

No response

Reproducible in the demo app?

Yes

Reproduction steps

SsaDecoder uses utf8 by default, if you play subtitles in utf16 encoding format, there will be problems

Expected result

ass subtitles display normally

Actual result

SsaDecoder's parseHeader method equalsIgnoreCase cannot judge equality normally

Media

ass

Bug Report

Activity

  1. changed the title [-]SsaDecoder 不支持 utf-16 编码的ass文件[/-] [+]SsaDecoder does not support utf-16 encoded ass files[/+] on Apr 13, 2023
  2. microkatz commented on May 4, 2023

    @microkatz
    Contributor

    Hello @viqbgrg.

    Thank you for logging your issue! We added support for utf-16 to the SsaDecoder. Here is a link, a9c8f2, to the commit to the main branch that added the feature. Hope this works! Please reopen if this does not fix your issue.

  3. locked and limited conversation to collaborators on Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions