Custom extras in MediaMetadataCompat not getting populated in "extras" field of MediaMetadata #756

Activity

1. Sachin-Radhakrishnan

   added

   needs triage

   question

   on Oct 22, 2023
2. icbaker

   self-assigned this

   on Oct 23, 2023
3. icbaker commented on Oct 23, 2023

   

   icbaker

   on Oct 23, 2023

   Collaborator

   More actions

   The conversion from MediaMetadataCompat to MediaMetadata is implemented here:

   media/libraries/session/src/main/java/androidx/media3/session/MediaUtils.java

   Lines 435 to 436 in c16accb

   	public static MediaMetadata convertToMediaMetadata(
   	@Nullable MediaMetadataCompat metadataCompat, @RatingCompat.Style int ratingType) {

   It uses known keys in MediaMetadataCompat to populated named/typed fields in MediaMetadata, but doesn't propagate unknown key/values into MediaMetadata.extras.

   Can you provide a bit of context about what info you need to propagate across? Is it keys that are defined on MediaMetadataCompat but that don't have a matching field in MediaMetadata, or is it completely custom keys in MediaMetadataCompat? It's not obvious to me that MediaMetadataCompat is intended to support completely custom keys.
4. icbaker

   added

   need more info

   and removed

   needs triage

   on Oct 23, 2023
5. Sachin-Radhakrishnan commented on Oct 23, 2023

   

   Sachin-Radhakrishnan

   on Oct 23, 2023

   Author

   More actions

   @icbaker Yes, it is the keys that are defined in MediaMetadataCompat that does not have a matching field in MediaMetadata.

   Standard keys were used to populate most of the values in MediaMetadataCompat , but there are some situations where some custom keys have been used to pass on some values.

   Please find the sample code snippet below

   val builder=MediaMetadataCompat.Builder()
   builder.putString(MediaMetadataCompat.METADATA_KEY_TITLE,"520")
   builder.putString(MediaMetadataCompat.METADATA_KEY_DISPLAY_SUBTITLE,"AM")
   builder.putString("radio_station_frequency_in_hertz","500000")
   builder.build()
   

   We are expecting "radio_station_frequency_in_hertz" to be part of the MediaMetadata.extras.

   Migrating the service code to use media3 APIs is beyond our control, so it will be better if such custom fields were also included as part of MediaMetadata.extras.

   Why can't the entire bundle of MediaMetadataCompat be included as part of MediaMetadata.extras just for backward compatibility? This will help us to continue using media3 APIs.
6. google-oss-bot

   added

   needs triage

   and removed

   need more info

   on Oct 23, 2023
7. icbaker

   assigned

   tianyif

   and unassigned

   icbaker

   on Oct 23, 2023
8. Sachin-Radhakrishnan commented on Oct 26, 2023

   

   Sachin-Radhakrishnan

   on Oct 26, 2023

   Author

   More actions

   @icbaker @tianyif Any update on this? Can we expect a fix?
9. tianyif commented on Oct 30, 2023

   

   tianyif

   on Oct 30, 2023

   Contributor

   More actions

   Hi @Sachin-Radhakrishnan, I'm working on a solution to this.
10. tianyif commented on Nov 1, 2023

    

    tianyif

    on Nov 1, 2023

    Last edited by tianyif

    Contributor

    More actions

    The fix was submitted to the dev branch: 84022ea
11. tianyif

    closed this as completedon Nov 1, 2023
12. androidx

    locked and limited conversation to collaborators on Jan 1, 2024