Repository navigation
Add Profile 20 support in Dolby Vision configuration data - #3427
Merged
copybara-service[bot] merged 1 commit intoSep 30, 2026
Merged
copybara-service[bot] merged 1 commit into
copybara-service[bot] merged 1 commit into
Conversation
Dolby Vision profile 20.0 content is currently misidentified as standard HEVC video in Media3, causing incorrect color display during playback. This happens because when parsing a Dolby Vision container, Media3 sets the MIME type to video/hevc upon encountering the HEVC configuration box. It is supposed to override this with video/dolby-vision after parsing the Dolby Vision configuration, but since profile 20 is not yet supported by the parser, the override never occurs — leaving the content incorrectly treated as HEVC. This fix ensures that profile 20.0 content is rejected on devices, rather than playing back with wrong colors. It is an independent contribution that does not depend on the pending AOSP changes for full profile 20 support.
| codecsPrefix = "dvav"; | ||
| } else if (dvProfile == 10) { | ||
| codecsPrefix = "dav1"; | ||
| } else if (dvProfile == 20) { |
There was a problem hiding this comment.
Maybe outside the scope of this PR, but seems like this whole if block could be written in a simpler way with switch (dvProfile)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dolby Vision profile 20.0 content is currently misidentified as standard HEVC video in Media3, causing incorrect color display during playback.
This happens because when parsing a Dolby Vision container, Media3 sets the MIME type to video/hevc upon encountering the HEVC configuration box. It is supposed to override this with video/dolby-vision after parsing the Dolby Vision configuration, but since profile 20 is not yet supported by the parser, the override never occurs — leaving the content incorrectly treated as HEVC.
This fix ensures that profile 20.0 content is rejected on devices, rather than playing back with wrong colors. It is an independent contribution that does not depend on the pending AOSP changes for full profile 20 support.