fix: handle container clean failing on read-only named volume mounts - #2228
Merged
Merged
Conversation
- Skip trim on read-only rootfs and read-only block mounts - Keep cleaning after a failure, then throw one error listing failed paths - Add integration tests for read-only rootfs, read-only volume, and mixed volumes Fixes apple#2224
Code Coverage
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container cleanfails withfilesystemOperation trim failedwhen the container has a named volume mounted read-only, because the runtime helper tries to trim every block mount and throws on the first error.The fix:
--read-only, and skips block mounts whose options includero.Fixes #2224
Testing