Repository navigation
[ty] Initialize constraint solver storage lazily - #29846
Draft
charliermarsh wants to merge 1 commit into
Draft
charliermarsh wants to merge 1 commit into
charliermarsh wants to merge 1 commit into
Conversation
charliermarsh
temporarily deployed
to
automations
October 30, 2026 16:22 — with 
GitHub Actions
Inactive
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for 58e183b · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 58e183b · Workflow run |
Contributor
|
| Project | Old Time | New Time | Change |
|---|---|---|---|
python-sop |
0.06s | 0.10s | +66% |
Flaky changes detected. This PR summary excludes flaky changes; see the HTML report for details.
Full report with detailed diff · Timing results
Results for 58e183b · Workflow run
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On the PyTorch benchmark, median
ty checktime fell from 8.40 s to 7.98 s (5.0%) across 18 paired runs of the standard release build. The change was faster in 15 pairs, and every run produced the same 30,293 diagnostics.ConstraintSetBuilderinitializes the arenas and caches for a decision diagram even when a type relation is already known to be always true or always false. We now initialize that storage on the first operation that needs it. Checks on terminal nodes return directly, and combining a constraint withtrueorfalseskips the diagram when the result and its source order are already known.