Repository navigation
[ty] Run Ruff and ty doctests as regular Rust tests - #29859
Open
charliermarsh wants to merge 4 commits into
Open
charliermarsh wants to merge 4 commits into
charliermarsh wants to merge 4 commits into
Conversation
charliermarsh
temporarily deployed
to
automations
October 31, 2026 12:59 — with 
GitHub Actions
Inactive
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for d8ede85 · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for d8ede85 · Workflow run |
Contributor
|
Contributor
|
charliermarsh
temporarily deployed
to
automations
October 31, 2026 13:08 — with
GitHub Actions
Inactive
charliermarsh
temporarily deployed
to
automations
October 31, 2026 17:49 — with
GitHub Actions
Inactive
charliermarsh
marked this pull request as ready for review
November 1, 2026 11:24
charliermarsh
requested review from
a team,
BurntSushi,
MichaReiser and
dhruvmanila
as code owners
November 1, 2026 11:24
charliermarsh
temporarily deployed
to
automations
November 1, 2026 11:44 — with
GitHub Actions
Inactive
MichaReiser
reviewed
Nov 1, 2026
Member
There was a problem hiding this comment.
How do we ensure that the tests stay up to date with the doctests?
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving 207 Rust doctests into the regular test suite cut the median warm test time for the affected crates from 70.6s to 59.0s (16.5%). The assertions now run under nextest, so CI skips the separate
cargo test --docstep. In one run per revision, the platform build and test steps were 8–13s faster.Hawk still compiles the documentation examples to see which public APIs they use. A warm Hawk run took 26.6s with the existing 16-crate limit and 32.1s across the whole workspace. Skipping that pass took 13.0s but produced 38
unnecessary_publicfindings.