WIP: Add new plugin (classAndFieldDecorators) for Stage-2 decorators proposal - #236
WIP: Add new plugin (classAndFieldDecorators) for Stage-2 decorators proposal#236DrewML wants to merge 2 commits into
Conversation
… in decorator expressions
|
Will this be breaking for cases like ? |
|
|
Breaking changes are something we need to figure out in Babel and Babylon. This kind of thing makes me wonder if we should add a |
|
How about
|
…ld reported by Logan
|
Should we make a new major version and remove the old decorator plugin and instead create the new ones? I think we also have other stuff that is breaking. node 4, deprecated plugins |
|
I think this PR is incorrect because
If my reading of the spec is correct, then
|
|
Going to close in favor of #587! |
This is one of several PRs that will be coming in (eventually) to start updating parsing to the latest draft of the decorators proposal (Stage 2).
Proposal is here.
The biggest change of the new latest proposal introduces a new type of
MemberExpressionproduction (DecoratorMemberExpression), that does not allow computed property access ([]). This was added to address the ambiguity between a computed member expr and a computed class property.TODO
hasPlugincheck forclassAndFieldDecoratorseverywhere that a check for thedecoratorsplugin is, that is also compliant with the latest revision of the proposal.decorators-legacytest folder