Skip to content

chore: Gpu workload chart - #6608

Merged
rupinsolanki07 merged 7 commits into
mainfrom
gpu-workload-chart
Jun 5, 2025
Merged

rupinsolanki07 merged 7 commits into
mainfrom
gpu-workload-chart

Conversation

@rupinsolanki07

Copy link
Copy Markdown
Contributor

Feat .. https://github.com/devtron-labs/sprint-tasks/issues/2304
This PR contains a chart for GPU workloads

@github-actions

Copy link
Copy Markdown

The migration files have successfully passed the criteria!!

@gitguardian

gitguardian Bot commented May 26, 2025

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9257608 Triggered Base64 AWS keys 962054e scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/test-values.json View secret
2763127 Triggered Generic High Entropy Secret 962054e scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/secrets-test-values.yaml View secret
141558 Triggered Generic High Entropy Secret 962054e scripts/devtron-reference-helm-charts/gpu-workload-4-21-0/env-values.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

{{- if $.Values.topologySpreadConstraint }}
topologySpreadConstraints:
{{ toYaml .Values.topologySpreadConstraint }}
{{- end }}

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted

<!--SONAR_ISSUE_KEY:AZcLm4kIC6Fubel6ulEI-->Bind this Service Account to RBAC or disable "automountServiceAccountToken". <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_devtron&issues=AZcLm4kIC6Fubel6ulEI&open=AZcLm4kIC6Fubel6ulEI&pullRequest=6608">SonarQube Cloud</a></p>
{{- end}}
{{- end}}
containers:
- name: {{ $.Chart.Name }}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced

<!--SONAR_ISSUE_KEY:AZcLm4kIC6Fubel6ulEH-->Specify a memory limit for this container. <p>See more on <a href="https://sonarcloud.io/project/issues?id=devtron-labs_devtron&issues=AZcLm4kIC6Fubel6ulEH&open=AZcLm4kIC6Fubel6ulEH&pullRequest=6608">SonarQube Cloud</a></p>
@sonarqubecloud

sonarqubecloud Bot commented Jun 5, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@rupinsolanki07
rupinsolanki07 merged commit a61bf2f into main Jun 5, 2025
@rupinsolanki07
rupinsolanki07 deleted the gpu-workload-chart branch June 5, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Sponsor
SponsoredKunjungi sekarang
Promo