Skip to content

Follow-ups to handling of includes and excludes in the UI #6400

Closed

Description

@Etsija

PR #6373.

A few after-the-fact review comments, as I did not have time to comment earlier:

  • I'm not so happy about the "Direction" wording, neither in the code, not in the UI. IMO e.g. "Type" would be a better fit.
  • The "Reason" should be align to e.g. vulnerability resolution reasons and use the capitalized enum name. I guess this will also simplify the code a bit, because the name can be taken as-is without a "prose form".
  • I feel we're a bit inconsistent about the trash-bin icon coloring. Shouldn't it be red?

Activity

  1. self-assigned this
    on Oct 30, 2026
  2. added
    uiIssues related to the UI.
    on Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

uiIssues related to the UI.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions