Skip to content

test: re-enable Node.js tests that now pass with BoringSSL - #55096

Merged
jkleinsc merged 1 commit into
45-x-yfrom
manual-bp/claude/pr/55071/branch/45-x-y
Oct 19, 2026
Merged

jkleinsc merged 1 commit into
45-x-yfrom
manual-bp/claude/pr/55071/branch/45-x-y

Conversation

@claude

@claude claude Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Requested by David Babenko-Sanders · Slack thread

Description of Change

Manually backport #55071. See that PR for details.

Validated locally against v45.0.0-beta.5 (3 runs): all 124 re-enabled test files and the 4 tests moved to the flaky list passed in every run.

Checklist

🤖 Generated with Claude Code

https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M

Release Notes

Notes: none

* test: re-enable Node.js tests that now pass with BoringSSL

Most of these were disabled because BoringSSL behaved differently from
OpenSSL. Upstream Node.js made the tests BoringSSL-aware in
nodejs/node#63161 (v24.18.0) and fixed the ML-KEM expectations in
nodejs/node#65966 (v24.22.0), so they now pass.

The es-module/test-esm-wasm entry is a stale prefix: test.py matches
entries as substrings of the path, so it was hiding 13 split files that
pass. A few entries are dropped because the tests now skip themselves.

parallel/test-cluster-primary-error, parallel/test-cluster-primary-kill,
parallel/test-diagnostics-channel-memory-leak and
parallel/test-worker-resource-limits move to the flaky list instead.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M

* test: keep two node tests disabled that crash on the testing build

test-vm-compile-function-lineoffset hits a V8 Smi::IsValid debug check and test-domain-error-types segfaults under --stress-compaction.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M

---------

Co-authored-by: Claude <noreply@anthropic.com>
(cherry picked from commit bcc5c51)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CfxP4tDxnGgFhy1kPesp3M
@claude

claude Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

The windows-x64 / build / build failure (job) is a transient Windows file-lock flake, not caused by this PR.

The Build Electron step stopped after 6778 actions with one failure, in Chromium's WebUI CSS generation (//ui/webui/resources/cr_components/composebox:css_wrapper_files). tools/polymer/css_to_wrapper.py couldn't delete its temp directory:

PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'W:\w\electron\electron\src\out\Default\gen\ui\webui\resources\cr_components\composebox\preprocessed\tmpnn4ltux_'

This PR only edits script/node-disabled-tests.json and script/node-flaky-tests.json. Only script/node-spec-runner.js reads those files, and they play no part in the Chromium/Electron build. The Windows x64 build passed on the recent 45-x-y branch runs; their failures were in Linux test shards, not Windows. I found no fix PR because this isn't a recurring problem.

I tried to re-run just this job, but GitHub refused because the rest of the workflow run is still in progress ("The workflow run containing this job is already running"). It needs a re-run of the failed jobs once the run completes.


Generated by Claude Code

@jkleinsc
jkleinsc merged commit c1cb681 into 45-x-y Oct 19, 2026
138 of 140 checks passed
@jkleinsc
jkleinsc deleted the manual-bp/claude/pr/55071/branch/45-x-y branch October 19, 2026 14:07
@release-clerk

release-clerk Bot commented Oct 19, 2026

Copy link
Copy Markdown

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants