chore: replace methods dependency with standard library - #6196
Merged
Merged
Conversation
Signed-off-by: Jon Koops <jonkoops@gmail.com>
3imed-jaberi
approved these changes
Dec 6, 2024
3imed-jaberi
left a comment
Member
There was a problem hiding this comment.
Since we no longer support Node.js versions earlier than 18, we can proceed with this!
+1
IamLizu
approved these changes
Jan 1, 2025
methods dependency with standard librarymethods dependency with standard library
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
methodsdependency with calls to the standard library of Node.js. Sincemethodsis mostly a polyfill forrequire('node:http').METHODSin older versions of Node.js that are no longer supported this can be removed.Works towards closing #4282