Repository navigation
fix(dev): Run the sidecar with --experimental-strip-types for Node 26 - #1364
Merged
Merged
Conversation
Node 26 removed --experimental-transform-types, so pnpm dev and pnpm dev:server exited with 'bad option' before starting.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 26 removed
--experimental-transform-types(nodejs/node#61803), so on Node 26 the dev scripts inpackages/spotlightexit before starting the sidecar:devanddev:servernow use--experimental-strip-types. The sidecar sources have no syntax that needs a transform (enums, namespaces, parameter properties), so stripping types is enough. The transform flag already required Node 22.7+, and--experimental-strip-typesexists since 22.6, so this doesn't narrow which Node versions can run the dev scripts.Tested locally from
packages/spotlight(node --experimental-strip-types src/run.ts, afterpnpm install):bad option. After,Spotlight listening on 8969.Spotlight listening on 8969.Only these two dev scripts change. Builds and the published CLI are unaffected. The repo's lint-staged hook also reformatted the
"files"array in the samepackage.jsononto one line (["dist"]).