lfshttp: fix auth response ExpiresIn data type - #6200
Merged
Merged
Conversation
chrisd8088
reviewed
Feb 5, 2026
chrisd8088
left a comment
Member
There was a problem hiding this comment.
Thanks very much for this enhancement!
I made a few minor suggestions, but the core functional changes all look great. Thanks again for this improvement!
aymanbagabas
force-pushed
the
expiresin-int64
branch
from
February 6, 2026 11:31
3955bc8 to
bc4b5f9
Compare
Contributor
Author
I've updated the PR with the suggested changes 🙂 |
The git config value "lfs.defaulttokenttl" can be larger than max int on i386 systems. We need to change this field to int64/time.Duration so that it can hold larger values. This commit also updates the Environment interface and add Int64 method to support fetching int64 values from git config. Fixes: charmbracelet/soft-serve#781 Co-authored-by: Chris Darroch <chrisd@apache.org> Signed-off-by: Ayman Bagabas <ayman.bagabas@gmail.com>
aymanbagabas
force-pushed
the
expiresin-int64
branch
from
February 12, 2026 09:25
e11e00b to
8bd20ae
Compare
chrisd8088
approved these changes
Feb 19, 2026
chrisd8088
left a comment
Member
There was a problem hiding this comment.
This looks great, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The git config value "lfs.defaulttokenttl" can be larger than max int on i386 systems. We need to change this field to int64/time.Duration so that it can hold larger values.
This commit also updates the Environment interface and add Int64 method to support fetching int64 values from git config.
Fixes: charmbracelet/soft-serve#781