Skip to content

PlayerView click handling if finger is lifted outside view #9861

Closed

Description

@ivk1800

If drag finger started on player view and end on outside view, triggered MotionEvent.ACTION_UP event and triggered toggle player controls. also if begin drag finger on playerview and end on it, player controls same triggered.

Reproduction steps:

open demo app, modify player_activity.xml set some fixed hegiht for playerview, example 100dp
run on device or emulator. play any example from list.

  • ExoPlayer version number: r2.16.1
  • Android version: any supported version
  • Android device: any supported device

Activity

  1. self-assigned this
    on Jan 13, 2022
  2. icbaker commented on Jan 13, 2022

    @icbaker
    Collaborator

    I can reproduce the described behaviour (using StyledPlayerView for completeness) - over to Olly to decide whether both of these are bugs and how to handle them:

    • drag finger starting on player view and end outside view: player controls are shown
    • drag finger starting on player view and elsewhere inside the view: player controls are shown

    I note that touching outside the player view and dragging a finger inside it before releasing does not trigger the controls.

  3. assigned and unassigned on Jan 13, 2022
  4. ojw28 commented on Mar 15, 2022

    @ojw28
    Contributor

    Fixed in dev-v2. The fix will be included in 2.18.

  5. locked and limited conversation to collaborators on May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions