Repository navigation
setPlaybackParameters() not overwriten by live adjusment - #10883
Closed
stevemayhew wants to merge 1 commit into
Closed
stevemayhew wants to merge 1 commit into
stevemayhew wants to merge 1 commit into
Conversation
There are multiple sequences of handler messages which can cause a user request to update playback speed to be overwritten by the `LivePlaybackSpeedControl` value. All the sequeunces share a common feature that: 1. a queued `MSG_PLAYBACK_PARAMETERS_CHANGED_INTERNAL` executes after the `MSG_SET_PLAYBACK_PARAMETERS` 2. The `PlaybackParameters` in this internal change are not the intended speed. The easiest way to reproduce this is with AC-3 pass-thru audio, in this case the audio renderer does not properly support speed change, see bug: google#10865 According to this commit, [Add back support for setting audio pitch](google@74c493f51e) [andrewlewis] This callback to report the internal speed change is needed for the renderers to run slow motion properly. In any event, there is no reason to propegate this internal speed change to the user speed setting (`ExoPlayerImplInternal.playbackParameters`). The change simply fixes `MSG_PLAYBACK_PARAMETERS_CHANGED_INTERNAL` not to update the user setting.
Contributor
Author
|
This is the fix for #10882 |
Contributor
Author
|
I'll open the same pull request on AndroidX.media if this one is acceptable. |
1 task
Collaborator
|
I'd suggest we continue the discussion on #10882. This PR doesn't fully work anyway I believe because it cuts out all potential updates to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are multiple sequences of handler messages which can cause a user request to update playback speed to be overwritten by the
LivePlaybackSpeedControlvalue.All the sequeunces share a common feature that:
MSG_PLAYBACK_PARAMETERS_CHANGED_INTERNALexecutes after theMSG_SET_PLAYBACK_PARAMETERSPlaybackParametersin this internal change are not the intended speed.The easiest way to reproduce this is with AC-3 pass-thru audio, in this case the audio renderer does not properly support speed change, see bug:
#10865
According to this commit,
Add back support for setting audio pitch [andrewlewis]
This callback to report the internal speed change is needed for the renderers to run slow motion properly.
In any event, there is no reason to propegate this internal speed change to the user speed setting (
ExoPlayerImplInternal.playbackParameters). The change simply fixesMSG_PLAYBACK_PARAMETERS_CHANGED_INTERNALnot to update the user setting.