Repository navigation
PGS subtitle decoding support - #3673
Conversation
|
Is it possible for you to host it somewhere and send a link (to dev.exoplayer@gmail.com)? Thanks. |
|
Email sent |
|
Got it, thanks. |
| int index = 0; | ||
| for (Holder curr : list) { | ||
| cues[index] = curr.build(); | ||
| cueStartTimes[index++] = curr.start_time; |
There was a problem hiding this comment.
Question: start_time is never assigned, and so is always 0. Does the PGS spec actually carry timestamps, or are the timestamps always provided out of band (i.e. elsewhere in the container)?
- If it can carry timestamps then there's something missing in this implementation.
- If they're always provided out of band then it's guaranteed that there's only a single event time for each sample, and hence there's no reason to pass any timestamps to
PgsSubtitle. This allowsPgsSubtitleto be simplified down to something that looks identical toDvbSubtitle.
No need to update this pull request as I'm going through tweaking it a bit anyway, but please clarify (same will apply to any other comments). Thanks!
There was a problem hiding this comment.
As far as I could tell the time stamps are only provided out of band, but I've only used this with MKV files. It would make sense to simplify this. It's been awhile since I wrote this. I think I was modeling it off of SubripDecoder/SubripSubtitle class at the time.
Where can I send a sample file? 83MB mkv file