Repository navigation
fix(bigquery): add jobRateLimitExceeded in jobRetryReasons - #9726
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b2e704d to
480752b
Compare
alvarowolfx
left a comment
There was a problem hiding this comment.
Can we add tests for this retry reason here ? Other than that, looks good to me
google-cloud-go/bigquery/bigquery_test.go
Line 28 in 6a7cd4f
shollyman
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
Your PR has reminded me that we don't properly exercise job retry behaviors in the existing unit tests, so I've opened 9751 against myself to add more testing surface.
dismissing test request due to current test structure
jobRateLimitExceededshould be added injobRetryReasonsso that these errors are automatically retried by the client.Other bigquery libraries, such as python-bigquery do so already.