Skip to content

Some test cases fail when the node executable is built by --shared #18535

Description

@yhwang

When use --shared option in configure, it would build the node in shared lib for people who embed node in their applications. It also uses the node_main.cc to build the node executable with the shared lib. When using this executable to run our existing test suites, the following test cases fail:

Ubuntu 16.04:

  • parallel/test-child-process-fork-exec-path
  • parallel/test-module-loading-globalpaths
  • parallel/test-postmortem-metadata
  • parallel/test-process-external-stdio-close
  • parallel/test-process-external-stdio-close-spawn
  • parallel/test-stdout-close-catch
  • abort/test-abort-backtrace

Maybe some of them are not suitable for shared lib build, maybe some are bugs. Fixing them would help us to have a CI job to build node in shared lib and verify it. This would also help embedding users to make sure the shared lib work. And we can start from Linux platform.

  • Platform: Linux
  • Subsystem: test

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    embeddingIssues and PRs related to embedding Node.js in another project.testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Sponsor
      SponsoredKunjungi sekarang
      Promo