Skip to content

build: addon tests need more descriptive names than test.js #6651

Description

@gibfahn
  • Version: 6.1.0
  • Platform: all
  • Subsystem: addon tests

When looking at test failures, the only way to identify which test failed is by the name. Unfortunately all the tests in the addons folder are called test.js, which leads to unhelpful output (see below).

Currently it looks like there is only one test.js file in each folder in test/addons, so the simplest solution would be to name each test $ADDON_NAME-test.js. If that makes sense I can open a PR to do it.

Sample output from the community CI

ok 1048 test.js
  ---
  duration_ms: 0.171
  ...
ok 1049 test.js
  ---
  duration_ms: 1.216
  ...
ok 1050 test.js
  ---
  duration_ms: 0.138
  ...
ok 1051 test.js
  ---
  duration_ms: 0.138
  ...
ok 1052 test.js
  ---
  duration_ms: 0.137
  ...
ok 1053 test.js
  ---
  duration_ms: 0.170
  ...
ok 1054 test.js
  ---
  duration_ms: 0.138
  ...
ok 1055 test.js
  ---
  duration_ms: 0.141
  ...
ok 1056 test.js
  ---
  duration_ms: 0.137
  ...
ok 1057 test.js
  ---
  duration_ms: 0.263
  ...
ok 1058 test.js
  ---
  duration_ms: 0.329
  ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      Sponsor
      SponsoredKunjungi sekarang
      Promo