Skip to content

test: fix test-config-json-schema with --openssl-use-def-ca-store - #67200

Open
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:fix-test-config-json-schema
Open

test: fix test-config-json-schema with --openssl-use-def-ca-store#67200
aduh95 wants to merge 2 commits into
nodejs:mainfrom
aduh95:fix-test-config-json-schema

Conversation

@aduh95

@aduh95 aduh95 commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

@aduh95
test: fix test-config-json-schema with --openssl-use-def-ca-store
56b7fc7 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Nov 2, 2026
@codecov

codecov Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (70e1db3) to head (78b387e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #67200      +/-   ##
==========================================
- Coverage   90.69%   90.69%   -0.01%     
==========================================
  Files         797      797              
  Lines      278874   278880       +6     
  Branches    53635    53633       -2     
==========================================
- Hits       252934   252926       -8     
- Misses      16303    16318      +15     
+ Partials     9637     9636       -1

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Nov 2, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 2, 2026
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/78793/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @marco-ippolito