Skip to content

Requests: Scene collection and profile name checking - #560

Merged
Palakis merged 6 commits into
4.x-currentfrom
enhancement/various-todos
Sep 16, 2020
Merged

Palakis merged 6 commits into
4.x-currentfrom
enhancement/various-todos

Conversation

@tt2468

@tt2468 tt2468 commented Jul 11, 2020

Copy link
Copy Markdown
Member

Description

For SetCurrentProfile and SetCurrentSceneCollection, check if it exists before attempting to switch to it, and return an error if it does not exist.

Motivation and Context

Because the code told me to

How Has This Been Tested?

Tested OS(s): Ubuntu 20.04

Types of changes

  • Enhancement (modification to a current event/request which adds functionality)

Checklist:

  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

For `SetCurrentProfile` and `SetCurrentSceneCollection`, check if it
exists before attempting to switch to it, and return an error if it
does not exist.
@tt2468 tt2468 added this to the 4.9 milestone Jul 11, 2020
@Palakis
Palakis self-requested a review July 15, 2020 13:01
@Palakis
Palakis merged commit 56a17a9 into 4.x-current Sep 16, 2020
@tt2468
tt2468 deleted the enhancement/various-todos branch October 4, 2020 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants