Repository navigation
Remove PHP version contraint from the #[\NoDiscard] attribute rule #14586
Description
Feature request
The reasoning is the same as for the #[\Override] attribute.
TL;DR: (a) the explicit use of #[\NoDiscard] is already an opt-in by itself, and (b) I am eager to benefit from the attribute via static analysis even though I am still running on 8.4.
#[\NoDiscard]
function f(): int {
return random_int(0, 4);
}
f(); // PHPStan should warn, regardless of PHP versionOf course, the (void) cast remains available in PHP 8.5+ only.
Code snippet that illustrates the issue
https://phpstan.org/r/bdb96b34-86b0-45a2-9723-98612f87da6f
Expected output
The error on line 8 should not be restricted to PHP 8.5+.
Did PHPStan help you today? Did it make you happy in any way?
No response
Activity
staabm commentedon May 7, 2026
is this the idea as suggested here #13009 ? ondrej had a opinion about it back then
VincentLanglet commentedon Sep 13, 2026
Would you be interested on doing the PR @claudepache I think it's an easy one and we will ping ondrej on it ;)
staabm commentedon Sep 13, 2026
Ondrej had a strong opinion on it. Not sure we could accept it
See #13009 (comment)
VincentLanglet commentedon Sep 13, 2026
I saw ondrej answer but I feel like the argument is correct here:
claudepache commentedon Sep 14, 2026
Done: phpstan/phpstan-src#6444
phpstan-bot commentedon Sep 14, 2026
Closed via merging phpstan/phpstan-src#6444
github-actions commentedon Oct 16, 2026
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.