Repository navigation
False positive about empty array with foreach loop #15147
Description
Bug report
I have an empty ArrayObject, which can be populated (or not) by a called method and then I get the array to loop on it as described in snippet.
PHPStan signals a foreach.emptyArray error which I think is not relevant here.
Am I wrong?
Code snippet that reproduces the problem
https://phpstan.org/r/45eca57f-0a03-493a-984e-bf4c7ec33584
Expected output
No error reported as the array might be not empty
Did PHPStan help you today? Did it make you happy in any way?
No response
Activity
ondrejmirtes commentedon Sep 1, 2026
Yes, the knowledge what
$aliasis should definitely update after$this->populate($alias);Because it's an object passed by reference and this usually works fine in PHPStan (at least it invalidates remembered method calls on the object, but probably doesn't change the generics).Generics should change probably only if the initial object is empty (has NeverType templates). Otherwise it could lead to some unsound code.
Cleanup some phpstan-ignore directive (some waiting for bug fixed in …
Add regression test for #15147
Add regression test for #15147
Updated PHPStan to commit 3bc4b93d66c402b85a65111fdf572db5daf599ed
franck-paul commentedon Oct 27, 2026
Is the Playground using the last release or "last-dev-commit" of PHPStan?
As in my example (https://phpstan.org/r/45eca57f-0a03-493a-984e-bf4c7ec33584) I still have the error.
staabm commentedon Oct 27, 2026
the improved behaviour (the fixed bug) is only visible with enabled bleeding-edge for now: https://phpstan.org/r/42c879e8-2a76-4737-8395-ff78a3d9e441