Throwing an Error does not do anything? #15258

Activity

1. ondrejmirtes commented on Sep 17, 2026

   

   ondrejmirtes

   on Sep 17, 2026

   Member

   More actions

   Yeah I know, it's a bug I want to fix before release.

   This should be decided in MethodCallHandler, StaticCallHandler, FuncCallHandler, NewHandler.

   I'd be fine if ExpressionHandler continued to invoke NoopExpressionNode for all nodes that aren't the ones handled by the handlers listed above.

   And the handlers above could decide whether they want to invoke NoopExpressionNode based on whether the explicit throw point is about new ObjectType(Error::class) or not.
2. ondrejmirtes

   added

   bug

   on Sep 17, 2026
3. ondrejmirtes

   added this to the Easy fixes milestone on Sep 17, 2026
4. phpstan-bot commented on Sep 17, 2026

   

   phpstan-bot

   on Sep 17, 2026

   Contributor

   More actions

   @claudepache After the latest push in 2.3.x, PHPStan now reports different result with your code snippet:

   @@ @@
   -PHP 8.0 – 8.6 (1 error)
   -==========
   -
   -12: Expression "throw new \ValueError('cannot extract a prefix from a string that has no prefix')" on a separate line does not do anything.
   -
   -PHP 7.2 – 7.4 (3 errors)
   -==========
   -
   -12: Instantiated class ValueError not found.
   -12: Possibly impure instantiation of unknown class in pure function extract_prefix().
   -12: Throwing object of an unknown class ValueError.
   +12: Expression "throw new \ValueError('cannot extract a prefix from a string that has no prefix')" on a separate line does not do anything.

   Full report

   Line	Error
   12	Expression "throw new \ValueError('cannot extract a prefix from a string that has no prefix')" on a separate line does not do anything.
5. phpstan-bot commented on Sep 18, 2026

   

   phpstan-bot

   on Sep 18, 2026

   Contributor

   More actions

   Closed via merging phpstan/phpstan-src#6471
6. phpstan-bot

   closed this as completedon Sep 18, 2026
7. github-actions commented on Oct 20, 2026

   

   github-actionsBot

   on Oct 20, 2026 – with GitHub Actions

   More actions

   This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
8. github-actions

   locked as resolved and limited conversation to collaborators on Oct 20, 2026