Repository navigation
Conversation
phpstan/phpstan-src#5976 checks static calls through class-string unions, so $enumClass::isValidKey($value) with int|string $value is now reported against the method's @PARAM string $key. Casting keeps the lookup identical, since array keys normalise numeric strings to ints. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to phpstan/phpstan-src#5976, which checks static method calls through class-string unions. Merge both or neither.
EnumValidatorcalls$enumClass::isValidKey($value)with$enumClasstypedclass-string<ClabsEnum<int>>|class-string<ClabsEnum<string>>and$valuetypedint|string. That call was skipped before; now it's reported asParameter #1 $key of static method MyCLabs\Enum\Enum<int>::isValidKey() expects string, int|string given., which is what a directClabsEnum::isValidKey($value)call reports too. The(string)cast keeps the behaviour identical:isValidKey()looks the key up in an array, and PHP normalises numeric-string keys to ints.🤖 Generated with Claude Code
https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG