Skip to content

The java.import.gradle.arguments setting is a No-Op #1169

Closed
Closed
The java.import.gradle.arguments setting is a No-Op#1169
Assignees
snjeza
Labels
Gradlepreferences

Description

@lingocoder
lingocoder
opened on Nov 30, 2019

The Supported VS Code settings section of this project's Code page lists: „java.import.gradle.arguments: Arguments to pass to Gradle“. Disappointingly, setting that property's value to --gradle-user-home=<my.specified.location> has absolutely no effect. Likewise, setting its value to --refresh-dependencies has absolutely zero effect.

Environment
  • Operating System: Windows amd64
  • JDK version: OpenJDK 12
  • Visual Studio Code version: 1.40.1 (system setup)
  • Java extension version: 0.53.1
  • Gradle 5.2.1 - 6.0.1
Steps To Reproduce
  1. Open a Gradle project
  2. Type Ctrl + , for Settings
    • enter java.import.gradle.arguments in the Settings field
    • select the Workspace tab
    • enter --gradle-user-home=<some.user.specified.location> in the Arguments to pass to Gradle. field
  3. Do something that causes Gradle to execute a build. For instance...
    • Ctrl + Shift + B
  4. Observe that regardless of the value set for --gradle-user-home, it is never used by Gradle.
Current Result

Regardless of the value set for java.import.gradle.arguments in vscode-java's Settings, the arguments given to it are never used by Gradle.

Expected Result

In the case of java.import.gradle.arguments being set to --gradle-user-home=<some.user.specified.location>, Gradle is expected to do the same thing it is documented to do when the same argument is passed to Gradle's command line interface. That is, Gradle should use the specified existing location. If the location given to --gradle-user-home does not exist already, then Gradle should automatically create it and then use that newly-created location.

Activity

  1. fbricon commented on Dec 3, 2019

    @fbricon
    fbricon
    on Dec 3, 2019
    Collaborator

    might be a limitation of Buildship (or not). Can you check if this works as expected in Eclipse?

  2. lingocoder commented on Dec 3, 2019

    @lingocoder
    lingocoder
    on Dec 3, 2019
    Author

    Assuming the wizard in this screenshot is the way to set those properties for Eclipse...

    1169 a

    ...,then yeah, this screenshot of Eclipse shows what I would expect to see from setting that --refresh-dependencies argument in the above wizard and invoking Eclipse's/Buildship's Gradle — Refresh Gradle Project context menu...

    1169 b

    I can confirm with total certainty that the above wizard's Gradle user home field does exactly what I expect too.

  3. hannah23280 commented on Feb 29, 2020

    @hannah23280
    hannah23280
    on Feb 29, 2020

    Has this been solved? I also trying to set Gradle User home in VSCode , so that VSCode 's JAVA DEPENDENCIES section would display the correct paths (based on the value set in the Gradle User home) for the libraries listed under "Project and External Dependencies".

  4. snjeza
    self-assigned this
    on Mar 7, 2020

  5. snjeza commented on Mar 7, 2020

    @snjeza
    snjeza
    on Mar 7, 2020
    Collaborator

    Related to #1310 and #1319

  6. ob commented on Mar 18, 2020

    @ob
    ob
    on Mar 18, 2020

    Is this issue resolved? I have a custom init script that we pass to ./gradlew with the -I option:

    ./gradlew -I Path/to/my/custom/gradle-init-script.gradle

    I tried adding the following to .vscode/settings.json:

    {
  "java.import.gradle.arguments": "-I Path/to/my/custom/gradle-init-script.gradle"
}

    but it doesn't seem to have any effect.

  7. snjeza commented on Mar 18, 2020

    @snjeza
    snjeza
    on Mar 18, 2020
    Collaborator

    See #1310 (comment)

  8. sarahcpage commented on Sep 16, 2021

    @sarahcpage
    sarahcpage
    on Sep 16, 2021

    please fix this

  9. jumble commented on Nov 5, 2021

    @jumble
    jumble
    on Nov 5, 2021

    @snjeza Is there a path forward on this issue?

  10. mozhuanzuojing commented on Nov 5, 2021

    @mozhuanzuojing
    mozhuanzuojing
    on Nov 5, 2021
    Contributor

    @CsCherrYY please watch this .
    It related by microsoft/vscode-gradle#1077

  11. snjeza commented on Nov 5, 2021

    @snjeza
    snjeza
    on Nov 5, 2021
    Collaborator

    I tried adding the following to .vscode/settings.json:
    Is there a path forward on this issue?

    @jumble could you try to add the java.import.gradle.arguments property to User Settings?

  12. mozhuanzuojing commented on Nov 6, 2021

    @mozhuanzuojing
    mozhuanzuojing
    on Nov 6, 2021
    Contributor

    I tried adding the following to .vscode/settings.json:
    Is there a path forward on this issue?

    @jumble could you try to add the java.import.gradle.arguments property to User Settings?

    @snjeza After I tested, the gradle service failed to start

    C:\Users\Administrator\AppData\Roaming\Code - Insiders\User\settings.json

    "java.import.gradle.jvmArguments": "-XX:+UseShenandoahGC -Xms1g -Xmx4g",

  13. snjeza commented on Nov 6, 2021

    @snjeza
    snjeza
    on Nov 6, 2021
    Collaborator

    @mozhuanzuojing Could you try to set java.import.gradle.arguments instead of java.import.gradle.jvmArguments and attach your logs?

  14. mozhuanzuojing commented on Nov 7, 2021

    @mozhuanzuojing
    mozhuanzuojing
    on Nov 7, 2021
    Contributor

    @snjeza arguments is not effect. I think this parameter is not recognized by https://github.com/microsoft/vscode-gradle .
    because java.import.gradle.user.home is ok.

    settings.json

    // Arguments to pass to Gradle.
"java.import.gradle.arguments": "--gradle-user-home=D:/java/gradlehome",
// Setting for GRADLE_USER_HOME.
// "java.import.gradle.user.home": "D:/java/gradlehome",

    gradle home sreen

    image

  15. CsCherrYY commented on Nov 8, 2021

    @CsCherrYY
    CsCherrYY
    on Nov 8, 2021
    Contributor

    @CsCherrYY please watch this . It related by microsoft/vscode-gradle#1077

    Not sure If they're related, currently vscode-java and vscode-gradle are separate extensions and vscode-gradle will consume some settings of vscode-java. That's the only way the two extensions work together now, though we have a plan to reuse the daemons and so on.

    In the above discussion, I find vscode-gradle supports java.import.gradle.jvmArguments only, not java.import.gradle.arguments.

  16. jumble commented on Nov 10, 2021

    @jumble
    jumble
    on Nov 10, 2021

    I tried adding the following to .vscode/settings.json:
    Is there a path forward on this issue?

    @jumble could you try to add the java.import.gradle.arguments property to User Settings?

    I can partially verify @CsCherrYY 's above statement. Specifying values for java.import.gradle.arguments in user settings does not affect Java or Gradle execution.

  17. CsCherrYY commented on Apr 14, 2022

    @CsCherrYY
    CsCherrYY
    on Apr 14, 2022
    Contributor

    With the newest extension (1.5.0), I can pass the arguments like --gradle-user-home mentioned via java.import.gradle.arguments and Gradle makes use of them successfully.

  18. testforstephen
    added
    Gradle
    preferences
    on Feb 13, 2023
  19. jdneo
    closed this as completedon Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Gradlepreferences

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions