Skip to content

fix: Improve attribute completions without snippet - #23523

Merged
ChayimFriedman2 merged 1 commit into
rust-lang:masterfrom
A4-Tacks:attr-without-snippet-cap
Oct 18, 2026
Merged

ChayimFriedman2 merged 1 commit into
rust-lang:masterfrom
A4-Tacks:attr-without-snippet-cap

Conversation

@A4-Tacks

@A4-Tacks A4-Tacks commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Fixes #23521

Other bad implements:

  • complete 'lookup': bad lookup: "docalias"
  • complete derive(: unpaired parentheses are bad
  • strip 'insert_snippet': a bit complicated

Example

"suggest.snippetsSupport": false

#[$0]

Before this PR

#[derive(…)]

After this PR

#[derive]

Example
---
`"suggest.snippetsSupport": false`

```rust
#[$0]
```

**Before this PR**

```rust
#[derive(…)]
```

**After this PR**

```rust
#[derive]
```
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2026

@ChayimFriedman2 ChayimFriedman2 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO completing derive( is reasonable but this is too. I'd prefer not doing such hack and instead manually giving the completion but this might be too much.

View changes since this review

@ChayimFriedman2
ChayimFriedman2 added this pull request to the merge queue Oct 18, 2026
Merged via the queue into rust-lang:master with commit 5ec20d0 Oct 18, 2026
20 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2026
@A4-Tacks
A4-Tacks deleted the attr-without-snippet-cap branch October 19, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completions insert (…) when client disabled snippet support

3 participants