Add `layout_variable_fonts_enabled` to experimental preferences by simonwuelker · Pull Request #40861 · servo/servo

simonwuelker · 2025-11-24T14:19:17Z

TimvdLippe · 2025-11-24T14:38:40Z

If you enable it for WPT, why not add it to experimental web features? That's already enabled for WPT and that way it is easier to debug run locally as well.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker · 2025-11-24T14:49:16Z

If you enable it for WPT, why not add it to experimental web features? That's already enabled for WPT and that way it is easier to debug run locally as well.

I have added it to the experimental features (thats the first half of this change). I didn't know we run WPT with experimental features, so I have reverted the changes to the __dir__.ini files.

github-actions · 2025-11-24T14:49:58Z

🔨 Triggering try run (#19638456021) for Linux (WPT)

github-actions · 2025-11-24T15:50:54Z

Test results for linux-wpt from try job (#19638456021):

Flaky unexpected result (46)

OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

CRASH [expected PASS] /_mozilla/shadow-dom/move-element-with-ua-shadow-tree-crash.html (#39473)
OK /_mozilla/webxr/create_session.https.html
- FAIL [expected PASS] subtest: create_session
```
can't access property "simulateDeviceConnection", navigator.xr.test is undefined
```

OK /_mozilla/webxr/obtain_frame.https.html

FAIL [expected PASS] subtest: obtain_frame

promise_test: Unhandled rejection with value: object "TypeError: can't access property "simulateDeviceConnection", navigator.xr.test is undefined"

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)
- PASS [expected FAIL] subtest: WebGL test #45
- PASS [expected FAIL] subtest: WebGL test #47
- PASS [expected FAIL] subtest: WebGL test #49
- PASS [expected FAIL] subtest: WebGL test #51
- FAIL [expected PASS] subtest: WebGL test #53
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #55
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #57
```
assert_true: Texture was smaller than the expected size 2x2 expected true got false
```
- FAIL [expected PASS] subtest: WebGL test #59
```
assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false
```
- PASS [expected FAIL] subtest: WebGL test #61
- PASS [expected FAIL] subtest: WebGL test #63
- And 10 more unexpected results...
CRASH [expected OK] /_webgl/conformance2/canvas/to-data-url-with-pack-params.html
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- FAIL [expected PASS] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
```
assert_unreached: The IFrame should have been blocked (or cross-origin). It wasn't. Reached unreachable code
```
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-serif (drawing text in a canvas)
OK /custom-elements/form-associated/ElementInternals-setFormValue.html (#29174)
- PASS [expected FAIL] subtest: Single value - empty name exists
- PASS [expected FAIL] subtest: Single value - Non-empty name exists
- PASS [expected FAIL] subtest: Null value should submit nothing
CRASH [expected ERROR] /dom/abort/AbortSignal.https.any.shadowrealm-in-audioworklet.html (#38763)
CRASH [expected ERROR] /encoding/encodeInto.any.serviceworker.html
CRASH [expected ERROR] /encoding/streams/decode-non-utf8.any.serviceworker.html
CRASH [expected OK] /fetch/content-encoding/zstd/zstd-body.https.any.worker.html
CRASH [expected OK] /fetch/metadata/generated/window-location.sub.html
TIMEOUT [expected CRASH] /fetch/metadata/window-open.https.sub.html (#40339)
CRASH [expected ERROR] /fetch/range/general.any.serviceworker.html
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- PASS [expected FAIL] subtest: link click
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
- PASS [expected FAIL] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/canvas/element/canvas-host/2d.canvas.host.size.attributes.setAttribute.whitespace.html
CRASH [expected OK] /html/capability-delegation/delegate-fullscreen-request-popup-same-origin.https.tentative.html
CRASH [expected TIMEOUT] /html/capability-delegation/delegation-consumes-activation.https.tentative.html
CRASH [expected OK] /html/infrastructure/urls/base-url/document-base-url-initiated-grand-parent.https.window.html
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-nonexistent.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with non-existent fragments should work.
```
Test timed out
```
CRASH [expected OK] /html/semantics/embedded-content/media-elements/autoplay-default-feature-policy.https.sub.html
OK /html/semantics/embedded-content/media-elements/seeking/seek-to-max-value.htm (#40626)
- FAIL [expected PASS] subtest: seek to Number.MAX_VALUE
```
assert_equals: currentTime after setting expected 5.153333333 but got 0
```
OK /html/semantics/forms/form-submission-0/multipart-formdata.window.html (#28725)
- FAIL [expected PASS] subtest: multipart/form-data: Basic test (formdata event)
```
assert_equals: expected "\r\nContent-Disposition: form-data; name=\"basic\"\r\n\r\ntest\r\n--\r\n" but got ""
```
OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
- FAIL [expected PASS] subtest: text/plain: Basic test (formdata event)
```
assert_equals: expected "basic=test\r\n" but got ""
```
- FAIL [expected PASS] subtest: text/plain: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt\r\n" but got ""
```
- PASS [expected FAIL] subtest: text/plain: 0x00 in name (formdata event)
- PASS [expected FAIL] subtest: text/plain: 0x00 in value (normal form)
- PASS [expected FAIL] subtest: text/plain: \r\n in filename (normal form)
OK /html/semantics/forms/form-submission-0/urlencoded2.window.html (#28687)
- FAIL [expected PASS] subtest: application/x-www-form-urlencoded: Basic File test (normal form)
```
assert_equals: expected "basic=file-test.txt" but got ""
```
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in name (normal form)
- PASS [expected FAIL] subtest: application/x-www-form-urlencoded: 0x00 in value (formdata event)
OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730, #39631)
CRASH [expected ERROR] /html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-resolve.any.serviceworker-module.html

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /preload/preload-xhr.html (#39092)
- FAIL [expected PASS] subtest: Make an XHR request immediately after creating link rel=preload.
```
assert_equals: resources/dummy.xml?token=f7f060cf-01d1-47f3-a33a-53fd63e1f9c0 expected 1 but got 0
```
CRASH [expected OK] /referrer-policy/gen/iframe.http-rp/origin/script-tag.http.html
CRASH [expected OK] /referrer-policy/gen/top.meta/no-referrer-when-downgrade/script-tag.http.html
OK /service-workers/service-worker/fetch-event.https.html (#36234)
- PASS [expected FAIL] subtest: Service Worker falls back to network in fetch event with POST form
CRASH [expected OK] /trusted-types/Node-multiple-arguments.html
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
CRASH [expected OK] /upgrade-insecure-requests/gen/iframe-blank-inherit.meta/unset/worklet-paint.https.html
CRASH [expected OK] /wasm/webapi/esm-integration/wasm-to-wasm-link-error.tentative.html
OK [expected ERROR] /webxr/render_state_update.https.html (#27535)
OK /xhr/open-url-multi-window-5.htm (#23360)
- FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)
```
assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw
```

Stable unexpected results that are known to be intermittent (22)

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(kai)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(nastaliq)
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/alignment/row-grid-lanes-align-self-003.html (#40833)
FAIL [expected PASS] /css/css-grid/grid-lanes/tentative/grid-placement/row-explicit-placement-004.html (#40834)
FAIL [expected PASS] /css/css-grid/masonry/tentative/subgrid/column/masonry-subgrid-002f.html (#40830)
OK /fetch/fetch-later/permissions-policy/deferred-fetch-allowed-by-permissions-policy.https.window.html (#40478)
- PASS [expected FAIL] subtest: Permissions policy header: "deferred-fetch=*" allows fetchLater() in the top-level document.
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-origin destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- FAIL [expected PASS] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy cross-site destination
OK /fetch/metadata/generated/element-img-environment-change.https.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-site, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Cross-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Cross-Site -> Cross-Site, no attributes
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Origin -> Same-Site, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Origin -> Cross-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Same Origin, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - Same-Site -> Same-Site, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-site - Same-Site -> Cross-Site, no attributes
- FAIL [expected PASS] subtest: sec-fetch-mode - attributes: crossorigin
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
- PASS [expected FAIL] subtest: sec-fetch-user - no attributes
- And 1 more unexpected results...
OK /fetch/metadata/generated/element-img-environment-change.sub.html (#30111)
- PASS [expected FAIL] subtest: sec-fetch-site - Not sent to non-trustworthy same-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-mode - Not sent to non-trustworthy cross-site destination, no attributes
- PASS [expected FAIL] subtest: sec-fetch-user - Not sent to non-trustworthy cross-site destination, no attributes
- FAIL [expected PASS] subtest: sec-fetch-site - HTTPS downgrade-upgrade, no attributes
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
ERROR /fetch/metadata/generated/serviceworker.https.sub.html (#36247)
- FAIL [expected PASS] subtest: sec-fetch-site - Same origin, no options - registration
```
promise_test: Unhandled rejection with value: object "Error: Failed to query for recorded headers."
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/autofocus-dialog.html (#29087)
- FAIL [expected TIMEOUT] subtest: <dialog>-contained autofocus element gets focused when the dialog is shown
```
promise_test: Unhandled rejection with value: object "TypeError: can't access property "show", w.document.querySelector(...) is null"
```
OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- FAIL [expected TIMEOUT] subtest: Element with tabindex should support autofocus
```
assert_equals: expected "SPAN" but got "BODY"
```
- PASS [expected NOTRUN] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got null
```
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;
```
- FAIL [expected NOTRUN] subtest: Area element should support autofocus
```
promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"
```
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
CRASH [expected OK] /pointerevents/compat/pointerevent_touch-action_two-finger_interaction.html (#40418)
OK [expected ERROR] /resource-timing/cors-preflight.any.html (#28694)
TIMEOUT [expected OK] /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- TIMEOUT [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls w/ default policy in report-only mode.
- NOTRUN [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
- NOTRUN [expected PASS] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in enforcing mode.
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

Stable unexpected results (2)

OK /css/css-fonts/animations/font-variation-settings-composition.html
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 50] from add ['test' 100] to replace ['test' 200] at (1) should be ['test' 200]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to replace ['test' 200] at (-0.3) should be [normal]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to replace ['test' 200] at (0) should be [normal]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to replace ['test' 200] at (0.5) should be ['test' 200]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to replace ['test' 200] at (1) should be ['test' 200]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to replace ['test' 200] at (1.5) should be ['test' 200]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to add ['test' 200] at (-0.3) should be [normal]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add [normal] to add ['test' 200] at (0) should be [normal]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add ['aaaa' 20, 'bbbb' 50] to add ['aaaa' 30, 'bbbb' 100] at (-0.3) should be ['aaaa' 17, 'bbbb' 35]
- PASS [expected FAIL] subtest: Compositing CSS Animations: property <font-variation-settings> underlying ['test' 100] from add ['aaaa' 20, 'bbbb' 50] to add ['aaaa' 30, 'bbbb' 100] at (0) should be ['aaaa' 20, 'bbbb' 50]
- And 3 more unexpected results...
PASS [expected FAIL] /css/css-fonts/variations/variable-gsub.html

github-actions · 2025-11-24T15:51:03Z

⚠️ Try run (#19638456021) failed.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025

Add layout_variable_fonts_enabled to experimental web platform features

c20c309

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker force-pushed the enable-layout-variable-fonts branch from 5095b81 to d4fa060 Compare November 24, 2025 14:48

simonwuelker changed the title ~~Add layout_variable_fonts_enabled to experimental prefs and enable it for wpt~~ Add layout_variable_fonts_enabled to experimental prefs Nov 24, 2025

simonwuelker changed the title ~~Add layout_variable_fonts_enabled to experimental prefs~~ Add layout_variable_fonts_enabled to experimental preferences Nov 24, 2025

simonwuelker added the T-linux-wpt Do a try run of the WPT label Nov 24, 2025

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Nov 24, 2025

TimvdLippe approved these changes Nov 24, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025

Update WPT expectations

0f7a720

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>

simonwuelker force-pushed the enable-layout-variable-fonts branch from d4fa060 to 0f7a720 Compare November 24, 2025 18:01

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 24, 2025

simonwuelker enabled auto-merge November 24, 2025 18:02

simonwuelker added this pull request to the merge queue Nov 24, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 24, 2025

Merged via the queue into servo:main with commit 941aa63 Nov 24, 2025
35 checks passed

simonwuelker deleted the enable-layout-variable-fonts branch November 24, 2025 19:40

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 24, 2025

Navigation Menu

Repository navigation

Add `layout_variable_fonts_enabled` to experimental preferences - #40861

Add `layout_variable_fonts_enabled` to experimental preferences #40861
simonwuelker merged 2 commits into
servo:mainfrom
simonwuelker:enable-layout-variable-fonts

simonwuelker commented Nov 24, 2025

Uh oh!

TimvdLippe commented Nov 24, 2025

Uh oh!

simonwuelker commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

simonwuelker commented Nov 24, 2025

Uh oh!

TimvdLippe commented Nov 24, 2025

Uh oh!

simonwuelker commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

github-actions Bot commented Nov 24, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants