Repository navigation
wpt: Make /_mozilla/mozilla/getBoundingClientRect.html wait for fonts to load - #44248
Conversation
…ts to load This is a speculative fix for servo#39668. Although I could not get this test to flake locally, it is obviously wrong to assumee that web fonts (Ahem in this case) is loaded at the time of `window.onload`. This change makes all the tests Promise tests and has them await `document.fonts.ready` before running. This should fix the intermittency. Signed-off-by: Martin Robinson <mrobinson@fastmail.fm>
|
I bet this was written when we still had a cli flag to make all font loads synchronous. |
That's a very reasonable explanation. |
Not obviously wrong, in fact some browsers indeed wait for fonts before firing But this test was running |
Servo does not, so just obvious in the case of Servo, I guess. :)
Yes, that was a mistake in in the PR message as it was copied from #44247. I'll update it here for future reference. |
This is a speculative fix for #39668. Although I could not get this test
to flake locally, it is obviously wrong to assumee that web fonts (Ahem
in this case) is loaded at the time script was run. This change
makes all the tests Promise tests and has them await
document.fonts.readybefore running. This should fix theintermittency.
Testing: This should fix intermittency as seen on the CI.
Fixes: #39668