fetch: implement Request navigation flags by Taym95 · Pull Request #46917 · servo/servo

Taym95 · 2026-07-31T15:59:46Z

Implement Request.isReloadNavigation and Request.isHistoryNavigation.

Testing: tests/wpt/meta/fetch/api/idlharness.https.any.js.ini and tests/wpt/meta/fetch/api/request/request-structure.any.js.ini

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

github-actions · 2026-07-31T16:51:15Z

🔨 Triggering try run (#30648752771) for Linux (WPT)

github-actions · 2026-07-31T17:24:14Z

Test results for linux-wpt from try job (#30648752771):

Flaky unexpected result (37)

CRASH [expected OK] /_mozilla/mozilla/hit-test-pos-fixed.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-06.html
CRASH [expected OK] /_webgl/conformance/uniforms/no-over-optimization-on-uniform-array-14.html
TIMEOUT [expected OK] /_webgl/conformance2/sync/sync-webgl-specific.html
CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html (#45255)
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
CRASH [expected OK] /css/compositing/canvas-composite-modes.html
OK /css/css-animations/event-order.tentative.html (#39000)
- PASS [expected FAIL] subtest: Same events on pseudo-elements follow the prescribed order
FAIL [expected PASS] /css/css-sizing/dynamic-available-size-iframe.html (#45763)
TIMEOUT [expected OK] /fetch/content-encoding/br/big-br-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large br data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large br data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/gzip/big-gzip-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large gzip data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large gzip data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
TIMEOUT [expected OK] /fetch/content-encoding/zstd/big-zstd-body.https.any.worker.html
- TIMEOUT [expected PASS] subtest: large zstd data should be decompressed successfully
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: large zstd data should be decompressed successfully with byte stream
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- PASS [expected FAIL] subtest: Link with onclick navigation and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

TIMEOUT [expected ERROR] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)
OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/update-the-rendering.html (#24145)
- TIMEOUT [expected FAIL] subtest: "Flush autofocus candidates" should be happen before a scroll event and animation frame callbacks
```
Test timed out
```
TIMEOUT /html/semantics/embedded-content/media-elements/autoplay-allowed-by-permissions-policy.https.sub.html (#46803)
- TIMEOUT [expected PASS] subtest: Permissions-Policy header: autoplay * allows same-origin iframes.
```
Test timed out
```

OK /html/semantics/embedded-content/media-elements/seeking/seek-to-currentTime.html (#46014)

FAIL [expected PASS] subtest: seek to currentTime

assert_array_equals: fired events lengths differ, expected array ["seeking", "timeupdate", "seeked"] length 3, got ["seeking", "timeupdate", "timeupdate", "seeked"] length 4

OK /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-reload-location-reload.html (#32595)
- FAIL [expected PASS] subtest: Reloading iframe loading='lazy' before it is loaded: location.reload
```
uncaught exception: Error: assert_equals: expected "http://web-platform.test:8000/html/semantics/embedded-content/the-iframe-element/support/blank.htm?src" but got "about:blank"
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html (#45151)
- TIMEOUT [expected FAIL] subtest: Post-navigation state reset.
```
Test timed out
```
OK /infrastructure/testdriver/click_iframe.html
- FAIL [expected PASS] subtest: TestDriver click on a document in an iframe
```
Unhandled rejection: assert_unreached: click failed Reached unreachable code
```
ERROR [expected OK] /intersection-observer/v2/animated-opacity.html (#40827)
OK /mixed-content/tentative/autoupgrades/video-upgrade.https.sub.html (#41135)
- FAIL [expected PASS] subtest: Video autoupgraded
```
assert_equals: Length. expected 1 but got Infinity
```
OK /paint-timing/with-lcp/fcp-document-opacity-image.html (#43068)
- FAIL [expected PASS] subtest: Test that FCP after opacity change is not a larger value than LCP
```
assert_equals: First contentful paint marked too early.  expected 0 but got 1
```
OK /resource-timing/buffer-full-then-increased.html (#44408)
- FAIL [expected PASS] subtest: Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 1
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
OK /touch-events/hover-state-caused-by-compatibility-mouse-events.tentative.html (#46277)
- PASS [expected FAIL] subtest: The compatibility mouse events should set :hover: The compatibility mouse events should be fired
- PASS [expected FAIL] subtest: The compatibility mouse events should set :hover, but shouldn't be preserved after the target is replaced: The compatibility mouse events should be fired
CRASH [expected OK] /trusted-types/script-enforcement-016.html
OK /trusted-types/trusted-types-navigation.html?16-20 (#44835)
- PASS [expected FAIL] subtest: Navigate a frame via area with javascript:-urls in report-only mode.
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK /upgrade-insecure-requests/gen/sharedworker-classic-data.meta/upgrade/websocket.https.html
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects allowed for websocket to cross-ws-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'allowed'. expected "allowed" but got "blocked"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects allowed for websocket to same-ws-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'allowed'. expected "allowed" but got "blocked"
```
OK /upgrade-insecure-requests/gen/sharedworker-module-data.meta/unset/fetch.https.html
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-http-downgrade origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-http-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to cross-https origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-http-downgrade origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-http-downgrade origin and no-redirect redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
- FAIL [expected PASS] subtest: Upgrade-Insecure-Requests: Expects blocked for fetch to same-https origin and downgrade redirection from https context.
```
assert_equals: The resource request should be 'blocked'. expected "blocked" but got "allowed"
```
CRASH [expected OK] /websockets/Close-1000-verify-code.any.worker.html?wss

Stable unexpected results that are known to be intermittent (12)

OK /beacon/beacon-basic.https.window.html (#41723)
- FAIL [expected PASS] subtest: Payload size restriction should be accumulated: type = string
```
assert_false: expected false got true
```
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-user - Not sent to non-trustworthy same-site destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)
- PASS [expected FAIL] subtest: Same-Document Referrer from Refresh
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus
```
Test timed out
```
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
- NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
- NOTRUN [expected FAIL] subtest: Area element should support autofocus
TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/autoplay-disabled-by-permissions-policy.https.sub.html (#46012, #46804)
- TIMEOUT [expected PASS] subtest: Permissions-Policy header: autoplay "none" has no effect on the top level document.
```
Test timed out
```
OK [expected TIMEOUT] /html/syntax/parsing/html5lib_write.html?file=processing-instructions (#46205)
OK /pointerevents/pointerevent_change-touch-action-onpointerdown_touch.html (#46781)
- FAIL [expected PASS] subtest: scroll was received while shouldn't
```
assert_true: scroll received while shouldn't expected true got false
```

OK /pointerevents/pointerevent_pointercapture_in_frame.html?touch (#45445)

FAIL [expected PASS] subtest: Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture.
```
assert_true: Timed out waiting for lostpointercapture expected true got false
```

FAIL [expected PASS] subtest:

Test touchpointer capture in same-origin frame: Pointer down at inner frame and set pointer capture to outer frame should not capture.

assert_array_equals: Received events: innerFrame received pointerdown,innerFrame received pointermove,innerFrame received pointerup,innerFrame received lostpointercapture lengths differ, expected array ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup"] length 3, got ["innerFrame received pointerdown", "innerFrame received pointermove", "innerFrame received pointerup", "innerFrame received lostpointercapture"] length 4

OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
OK /resource-timing/test_resource_timing.html (#25720)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (iframe)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (script)
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- TIMEOUT [expected PASS] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
```
Test timed out
```
- NOTRUN [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.

github-actions · 2026-07-31T17:24:23Z

✨ Try run (#30648752771) succeeded.

Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com> Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

fetch: implement Request navigation flags

532d8c7

Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

Taym95 requested a review from gterzian as a code owner July 31, 2026 15:59

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 31, 2026

Taym95 added the T-linux-wpt Do a try run of the WPT label Jul 31, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Jul 31, 2026

yezhizhen self-requested a review August 1, 2026 12:16

yezhizhen approved these changes Aug 1, 2026

View reviewed changes

Comment thread components/script/dom/fetch/request.rs Outdated

Comment thread components/constellation/constellation.rs

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Aug 1, 2026

Fix spec doc comments

cb3a860

Co-authored-by: Euclid Ye <yezhizhenjiakang@gmail.com> Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Aug 1, 2026

Taym95 enabled auto-merge August 1, 2026 20:06

Taym95 added this pull request to the merge queue Aug 1, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 1, 2026

Merged via the queue into servo:main with commit d97c8c9 Aug 1, 2026
36 checks passed

Taym95 deleted the fetch-request-navigation-flags branch August 1, 2026 21:00

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Aug 1, 2026

Navigation Menu

Repository navigation

fetch: implement Request navigation flags - #46917

fetch: implement Request navigation flags#46917
Taym95 merged 2 commits into
servo:mainfrom
Taym95:fetch-request-navigation-flags

Taym95 commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Taym95 commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

github-actions Bot commented Jul 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants