Skip to content

Add 'system-ui' to font stack. - #21356

Merged
mdo merged 1 commit into
twbs:v4-devfrom
bardiharborow:system-ui-font-stack
Dec 20, 2016
Merged

mdo merged 1 commit into
twbs:v4-devfrom
bardiharborow:system-ui-font-stack

Conversation

@bardiharborow

Copy link
Copy Markdown
Contributor

Fixes #21354.

@cvrebert cvrebert added css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages labels Dec 19, 2016
@mdo mdo added this to the v4.0.0-alpha.6 milestone Dec 20, 2016
@mdo
mdo merged commit da18d07 into twbs:v4-dev Dec 20, 2016
@mdo mdo mentioned this pull request Dec 20, 2016
@bardiharborow
bardiharborow deleted the system-ui-font-stack branch December 20, 2016 08:02
@klimashkin

Copy link
Copy Markdown

@bardiharborow Why system-ui is not first in list, why it should be after -apple-system?

@wolfy1339

wolfy1339 commented Apr 19, 2017 •

Copy link
Copy Markdown
Contributor

@klimashkin This was reverted in #22377 because​ it was causing issues

@GrimLink

GrimLink commented Dec 5, 2017 •

Copy link
Copy Markdown

@mdo I don't understand why system-ui i has been removed from the stack.
Instead move the "Segoe UI" before the value in the stack instead.

Maybe like this:
$font-family-sans-serif: -apple-system, "Segoe UI", system-ui, ... !default;
This way we can still have the advantage of the system-ui without having the Windows bug.
Also BlinkMacSystemFont is an older version of system-ui for chrome on OSX.
Since Chrome 56 we should use the newer version, system-ui

@mdo

mdo commented Dec 12, 2017

Copy link
Copy Markdown
Member

@GrimLink Read #22328 for the background on why it was reverted outright. We didn't test, as far as I know, changing the font stack's order, but if you have a demo of it fixing the problems listed in the referenced issue, please open a new issue to discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css Sass sources or compiled CSS v4 v4, the frozen docs on gh-pages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants