Repository navigation
Drop pytest-flake8 from test requirements to fix CI on pytest 9 - #137
Merged
Merged
Conversation
pytest-flake8 1.3.0 still declares the py.path `path` argument in its pytest_collect_file hook, which pytest 9 removed, so pytest refuses to load the plugin and CI fails before collecting any tests. The plugin is never enabled (no --flake8 in addopts) and linting already runs through ruff in pre-commit.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe test requirements remove ChangesTest requirements
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk was found in the dependency removal. Normal checks can proceed. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Collaborator
|
Thank you Cristian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CI testingworkflow currently fails on every OS before a single test is collected:pytest 9 removed the legacy py.path
pathhook argument, and the latest pytest-flake8 (1.3.0) still declares it, so pytest refuses to load the plugin. Nothing in the repo actually uses it (--flake8isn't inaddopts, and linting runs through ruff in pre-commit), so this just removes it fromtests/requirements.txt. The standaloneflake8entry is left as is.Tested locally on Python 3.11 with the same versions as the failing run (pytest 9.1.1, torch 2.14.1, transformers 5.18.0, datasets 5.1.0):
pytest src testsfails with the error aboveSummary by CodeRabbit