fix(vite): encode virtual IDs in global HMR updates - #5298
Merged
Merged
Conversation
✅ Deploy Preview for unocss ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Global mode stores UnoCSS entries as Vite internal virtual module IDs after #5284, but its HMR payload still sent the internal
\0-prefixed URL directly to the browser.Keep the internal ID for
moduleGraph.getModuleById()and invalidation, then encode null-byte IDs as Vite's public/@id/__x00__/...client path when sending the HMR update. Normal module URLs are preserved.This is a follow-up to #5284.
Fixes #5293
Validation
vitest run test/virtual-modules.test.tstsgo --noEmit