fix(transformer-directives): honor the deprecated varStyle option - #5305
Closed
rajanpanth wants to merge 1 commit into
Closed
rajanpanth wants to merge 1 commit into
rajanpanth wants to merge 1 commit into
Conversation
resolveApplyVariables computed applyVariable from varStyle and then overwrote it unconditionally on the next line, so the option had no effect: varStyle: false did not disable custom property apply, and a custom prefix was ignored. The default assignment now runs only when varStyle is not provided.
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
Member
|
This deprecated flag has been around for a long time. I plan to remove it in the next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolveApplyVariablescomputesapplyVariablefromvarStyleand then overwrites it unconditionally on the very next line:So the
varStyleoption has no effect at all. It is deprecated but still public and typedfalse | string:varStyle: falseis documented as the way to turn off custom-property@applyentirely, and it currently leaves all three defaults active.Change
The default assignment moves into an
else, so it only applies whenvarStyleis not provided.applyVariablestill takes precedence overvarStyle, which is the documented order.Tests
A new
apply variablesblock covering the defaults,varStyleas a string,varStyle: false, andapplyVariablewinning overvarStyle. Reverting only the source and keeping the tests fails withexpected [ Array(3) ] to deeply equal [ '--my-apply' ]; restored, the transformer-directives suite passes 78/78 and eslint is clean.