fix: remove format sniffing module resolution from JS resolver - #22297
Merged
sapphi-red merged 3 commits intoApr 22, 2026
Conversation
ghost
marked this pull request as draft
April 22, 2026 02:45
…ution-from-js-resolver
ghost
marked this pull request as ready for review
April 22, 2026 03:59
bluwy
approved these changes
Apr 22, 2026
commented
Apr 22, 2026
Member
|
Small nit, maybe the title should be scoped as |
ghost
deleted the
refactor/remove-format-sniffing-module-resolution-from-js-resolver
branch
April 22, 2026 08:24
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was not implemented on the native resolver: https://vite.dev/guide/migration#removed-module-resolution-using-format-sniffing
But was not removed from the JS resolver.