fix(runner): don't fail collection when accessing error.stack throws - #10839
Merged
Merged
Conversation
With `includeTaskLocation` enabled, the runner reads `error.stack` for every registered test and suite. Reading `.stack` invokes Vite's `prepareStackTrace` sourcemap interceptor, which currently throws `TypeError: Cannot assign to read only property 'constructor'` if the test file ran `Object.freeze(Object.prototype)`, failing collection of the whole file (vitest-dev/vscode#798). Move the `.stack` access into `findTestFileStackTrace` and guard it so the task just loses its location instead of failing collection.
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
includeTaskLocationenabled, the runner readserror.stackfor every registered test and suite. Reading.stackinvokes Vite'sprepareStackTracesourcemap interceptor, which throws if the test file ranObject.freeze(Object.prototype)(root cause fixed in vitejs/vite#23073), failing collection of the whole file. Guard the.stackaccess infindTestFileStackTraceso the task only loses its location.Fixes vitest-dev/vscode#798