fix(utils): don't crash on a malformed inline source map (fix #10892) by lazerg · Pull Request #10893 · vitest-dev/vitest

lazerg · 2026-08-08T08:01:56Z

Description

closes extractSourcemapFromFile crashes the run on a malformed source map, exiting non-zero with every test passing #10892

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
Ideally, include a test that fails without this PR but passes with it.
Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

Run the tests with pnpm test:ci.

Documentation

If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

lazerg · 2026-08-08T08:10:54Z

Both failing jobs look unrelated to this change. The Windows unit job fails the same way on main, in the typechecker OOM test. The macOS e2e job failed on a watch fixture that disappeared mid-run.

hi-ogawa

Should also try integration repro in vite and fix there too

vitest/packages/utils/src/source-map/node.ts

Lines 9 to 11 in 9ac9d43

    
           // based on vite 
        
           // https://github.com/vitejs/vite/blob/84079a84ad94de4c1ef4f1bdb2ab448ff2c01196/packages/vite/src/node/server/sourcemap.ts#L149 
        
           export function extractSourcemapFromFile(

lazerg · 2026-08-12T08:26:13Z

I checked vite's own extractSourcemapFromFile (packages/vite/src/node/server/sourcemap.ts). Both call sites already wrap it in try/catch, and the module runner has a separate fix (#20554) for the same sourceMappingURL-in-a-string-literal case, so this crash doesn't happen there and no follow-up is needed on that side.

#10892)

netlify · 2026-08-12T08:36:16Z

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`072276c`
🔍 Latest deploy log	https://app.netlify.com/projects/vitest-dev/deploys/6a7d239df2c8fd0008ae73e3
😎 Deploy Preview	https://deploy-preview-10893--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa · 2026-08-12T08:38:46Z

+  // Split across a concat so this file's own transform doesn't treat it as
+  // its own (malformed) source map comment.
+  const malformedSourceMapComment = '//# source' + 'MappingURL=data:application/json;base64,bm90LWpzb24='
+
+  const { stderr, exitCode, buildTree } = await runInlineTests({
+    'malformed-source-map.js': `${malformedSourceMapComment}


Can use real file fixture for better illustration.

Switched to a real fixture file, thanks for the nudge.

…source map test

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa · 2026-08-13T01:53:17Z

+              // TODO: this uses client module graph and thus miss detects
+              // inlined modules in ssr environment as if external.


Apparently test/e2e/fixtures/malformed-source-map/malformed-source-map.js case shouldn't have failed if we got this right. For now, just leaving inline TODO here and not creating its own issue since this misdetection doesn't have actually any consequence for mapping correctness (as we've covered extensively in other e2e).

fix(utils): don't crash on a malformed inline source map (fix #10892)

92bdce1

hi-ogawa self-requested a review August 12, 2026 08:15

hi-ogawa requested changes Aug 12, 2026

View reviewed changes

hi-ogawa self-assigned this Aug 12, 2026

hi-ogawa requested changes Aug 12, 2026

View reviewed changes

Comment thread test/unit/test/utils.spec.ts

test: add integration coverage for the malformed inline source map fix (

6b169a4

#10892)

hi-ogawa requested changes Aug 12, 2026

View reviewed changes

lazerg and others added 6 commits August 12, 2026 13:45

test: use a real fixture instead of an inline file for the malformed …

37a7f1f

…source map test

nit

dbdd4b9

test: cover malformed source maps in external modules

ee56bea

Co-authored-by: OpenCode <noreply@opencode.ai>

test: clarify malformed source map coverage

f1f2ab2

Co-authored-by: OpenCode <noreply@opencode.ai>

nit

bbe10be

chore: ignore malformed source map fixtures in lint

cb845f3

Co-authored-by: OpenCode <noreply@opencode.ai>

hi-ogawa mentioned this pull request Aug 13, 2026

chore: add bundled workspace dep build gotcha in AGENTS.md #10938

Merged

7 tasks

nit

b7da390

hi-ogawa reviewed Aug 13, 2026

View reviewed changes

Merge branch 'main' into fix/issue-10892-malformed-sourcemap

072276c

hi-ogawa approved these changes Aug 13, 2026

View reviewed changes

Merge branch 'main' into fix/issue-10892-malformed-sourcemap

c154a75

hi-ogawa merged commit fe79062 into vitest-dev:main Aug 14, 2026
26 of 28 checks passed

usetheodev mentioned this pull request Aug 23, 2026

ci: a suíte sai não-zero em Node 22.12 sem nenhum teste falhar — vitest lê uma string do bundle do tsx como sourcemap usetheokit/theokit#427

Closed

github-actions Bot locked and limited conversation to collaborators Aug 29, 2026

Navigation Menu

Uh oh!

Uh oh!

fix(utils): don't crash on a malformed inline source map (fix #10892) - #10893

fix(utils): don't crash on a malformed inline source map (fix #10892)#10893
hi-ogawa merged 11 commits into
vitest-dev:mainfrom
lazerg:fix/issue-10892-malformed-sourcemap

lazerg commented Aug 8, 2026 •

edited by hi-ogawa

Loading

Uh oh!

lazerg commented Aug 8, 2026

Uh oh!

hi-ogawa left a comment

Uh oh!

Uh oh!

lazerg commented Aug 12, 2026

Uh oh!

netlify Bot commented Aug 12, 2026 •

edited

Loading

Uh oh!

hi-ogawa Aug 12, 2026

Uh oh!

lazerg Aug 12, 2026

Uh oh!

hi-ogawa Aug 13, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// based on vite
	// https://github.com/vitejs/vite/blob/84079a84ad94de4c1ef4f1bdb2ab448ff2c01196/packages/vite/src/node/server/sourcemap.ts#L149
	export function extractSourcemapFromFile(

		// TODO: this uses client module graph and thus miss detects
		// inlined modules in ssr environment as if external.

Uh oh!

Uh oh!

Conversation

lazerg commented Aug 8, 2026 • edited by hi-ogawa Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Documentation

Changesets

Uh oh!

lazerg commented Aug 8, 2026

Uh oh!

hi-ogawa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lazerg commented Aug 12, 2026

Uh oh!

netlify Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for vitest-dev ready!

Uh oh!

hi-ogawa Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

lazerg Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

hi-ogawa Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lazerg commented Aug 8, 2026 •

edited by hi-ogawa

Loading

netlify Bot commented Aug 12, 2026 •

edited

Loading

hi-ogawa Aug 13, 2026 •

edited

Loading