Skip to content

fix(ui): fix code editor error and annotations gadgets layout shifts - #10969

Merged
sheremet-va merged 3 commits into
vitest-dev:mainfrom
hi-ogawa:ui-error-gadget-sync
Aug 17, 2026
Merged

sheremet-va merged 3 commits into
vitest-dev:mainfrom
hi-ogawa:ui-error-gadget-sync

Conversation

@hi-ogawa

@hi-ogawa hi-ogawa commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Description

The inline error and annotation gadgets currently rebuild through an unconditional 100 ms timeout. This makes the editor render first and then visibly shift when the gadgets appear.

This PR watches the code editor file loading state and renders gadgets synchronously at the same phase as code mirror initial render. The trace gutter already uses this pattern by watching the same loading state and updating synchronously.

📸 Before and After

Before

Screen.Recording.2026-08-17.at.15.49.44.mov

After

Screen.Recording.2026-08-17.at.15.47.38.mov

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Co-authored-by: OpenCode <noreply@opencode.ai>
@netlify

netlify Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4e87f30
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6a82a90620eb7300086329c9
😎 Deploy Preview https://deploy-preview-10969--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

hi-ogawa and others added 2 commits August 17, 2026 15:25
Co-authored-by: OpenCode <noreply@opencode.ai>
@hi-ogawa hi-ogawa changed the title fix(ui): render editor error gadgets without delay fix(ui): fix code editor error and annotations gadgets layout shifts Aug 17, 2026
@hi-ogawa
hi-ogawa marked this pull request as ready for review August 17, 2026 06:50

@sheremet-va sheremet-va left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, was really annoying how they jump

@sheremet-va
sheremet-va merged commit 438eda1 into vitest-dev:main Aug 17, 2026
27 of 28 checks passed
@hi-ogawa
hi-ogawa deleted the ui-error-gadget-sync branch August 17, 2026 07:56
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Sponsor
SponsoredKunjungi sekarang
Promo